You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "leixm (via GitHub)" <gi...@apache.org> on 2024/07/18 10:49:02 UTC
[PR] DynamicConfigServiceFactory should support singleton. [celeborn]
leixm opened a new pull request, #2635:
URL: https://github.com/apache/celeborn/pull/2635
### What changes were proposed in this pull request?
DynamicConfigServiceFactory supports singleton.
### Why are the changes needed?
Improve code.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Existing UTs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1516] DynamicConfigServiceFactory should support singleton. [celeborn]
Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on PR #2635:
URL: https://github.com/apache/celeborn/pull/2635#issuecomment-2238536779
> Thanks, could you create a jira ticket for this modify? @leixm
Sure, i updated title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1516] DynamicConfigServiceFactory should support singleton. [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2635: [CELEBORN-1516] DynamicConfigServiceFactory should support singleton.
URL: https://github.com/apache/celeborn/pull/2635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CELEBORN-1516] DynamicConfigServiceFactory should support singleton. [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2635:
URL: https://github.com/apache/celeborn/pull/2635#issuecomment-2238621125
Thanks, Merge to main(v0.6.0) and branch-0.5(v0.5.1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DynamicConfigServiceFactory should support singleton. [celeborn]
Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on PR #2635:
URL: https://github.com/apache/celeborn/pull/2635#issuecomment-2238387875
Thanks, could you create a jira ticket for this modify? @leixm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] DynamicConfigServiceFactory should support singleton. [celeborn]
Posted by "leixm (via GitHub)" <gi...@apache.org>.
leixm commented on PR #2635:
URL: https://github.com/apache/celeborn/pull/2635#issuecomment-2236202069
@RexXiong PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org