You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Sai Boorlagadda <sb...@pivotal.io> on 2015/12/16 22:08:17 UTC
Review Request 41466: GEODE-680: Chunk refactoring encountered while
writing unit tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41466/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
1) Promoted constant fields to default access level.
2) Modified getAddressForReading to delegate to getUnsafeAddress.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java ed4bc43b89487a84a060b146507a48ec63d1a203
gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 20cb8dc7d5f85243e01d3c1a5fb2cd4effb8faf4
Diff: https://reviews.apache.org/r/41466/diff/
Testing
-------
Thanks,
Sai Boorlagadda
Re: Review Request 41466: GEODE-680: Chunk refactoring encountered
while writing unit tests.
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41466/#review110763
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Dec. 16, 2015, 1:08 p.m., Sai Boorlagadda wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41466/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2015, 1:08 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> 1) Promoted constant fields to default access level.
> 2) Modified getAddressForReading to delegate to getUnsafeAddress.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/offheap/Chunk.java ed4bc43b89487a84a060b146507a48ec63d1a203
> gemfire-core/src/test/java/com/gemstone/gemfire/internal/offheap/GemFireChunkJUnitTest.java 20cb8dc7d5f85243e01d3c1a5fb2cd4effb8faf4
>
> Diff: https://reviews.apache.org/r/41466/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sai Boorlagadda
>
>