You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2023/03/10 01:24:22 UTC
[GitHub] [druid] gianm opened a new pull request, #13915: SuperSorter: Avoid storing extra writable channels.
gianm opened a new pull request, #13915:
URL: https://github.com/apache/druid/pull/13915
PR #13368 replaced a FrameFile cache with a PartitionedOutputChannel cache. Unfortunately, these objects are heavyweight: each has a writable channel and a frame memory allocator with an 8MB arena. This patch replaces it with a Supplier<PartitionedReadableFrameChannel>, which is lighter weight, and is all that was needed anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm closed pull request #13915: SuperSorter: Avoid storing extra writable channels.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm closed pull request #13915: SuperSorter: Avoid storing extra writable channels.
URL: https://github.com/apache/druid/pull/13915
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] gianm commented on pull request #13915: SuperSorter: Avoid storing extra writable channels.
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #13915:
URL: https://github.com/apache/druid/pull/13915#issuecomment-1463074371
#13755 fixes the same bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org