You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/02 16:23:18 UTC
[GitHub] [helix] zhangmeng916 opened a new pull request #1430: Add getResourceCustomized View REST API
zhangmeng916 opened a new pull request #1430:
URL: https://github.com/apache/helix/pull/1430
### Issues
- [X] My PR addresses the following Helix issues and references them in the PR description:
Fixed #1425
### Description
- [X] Here are some details about my PR, including screenshots of any UI changes:
We need a REST API for getting resource customized view for our users. This PR adds one in resource accessor.
### Tests
- [X] The following is the result of the "mvn test" command on the appropriate module:
helix-rest
[INFO] Tests run: 169, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 122.996 s - in TestSuite
[INFO]
[INFO] Results:
[INFO]
[INFO] Tests run: 169, Failures: 0, Errors: 0, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:09 min
[INFO] Finished at: 2020-10-02T09:20:49-07:00
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm merged pull request #1430: Add getResourceCustomized View REST API
Posted by GitBox <gi...@apache.org>.
pkuwm merged pull request #1430:
URL: https://github.com/apache/helix/pull/1430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] zhangmeng916 commented on pull request #1430: Add getResourceCustomized View REST API
Posted by GitBox <gi...@apache.org>.
zhangmeng916 commented on pull request #1430:
URL: https://github.com/apache/helix/pull/1430#issuecomment-702985610
This PR is ready to merge. Approved by @mgao0
Final commit message:
Add getResourceCustomized View REST API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 commented on a change in pull request #1430: Add getResourceCustomized View REST API
Posted by GitBox <gi...@apache.org>.
mgao0 commented on a change in pull request #1430:
URL: https://github.com/apache/helix/pull/1430#discussion_r498987635
##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestResourceAccessor.java
##########
@@ -162,6 +162,13 @@ public void testExternalView() throws IOException {
System.out.println("End test :" + TestHelper.getTestMethodName());
}
+ @Test(dependsOnMethods = "testExternalView")
+ public void testCustomizedView() {
+ System.out.println("Start test :" + TestHelper.getTestMethodName());
+ get("clusters/" + CLUSTER_NAME + "/resources/" + RESOURCE_NAME + "/customizedView", null,
+ Response.Status.NOT_FOUND.getStatusCode(), true);
+ }
+
Review comment:
Could you add a test case where the call returns something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 commented on a change in pull request #1430: Add getResourceCustomized View REST API
Posted by GitBox <gi...@apache.org>.
mgao0 commented on a change in pull request #1430:
URL: https://github.com/apache/helix/pull/1430#discussion_r499041051
##########
File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestResourceAccessor.java
##########
@@ -162,6 +162,13 @@ public void testExternalView() throws IOException {
System.out.println("End test :" + TestHelper.getTestMethodName());
}
+ @Test(dependsOnMethods = "testExternalView")
+ public void testCustomizedView() {
+ System.out.println("Start test :" + TestHelper.getTestMethodName());
+ get("clusters/" + CLUSTER_NAME + "/resources/" + RESOURCE_NAME + "/customizedView", null,
+ Response.Status.NOT_FOUND.getStatusCode(), true);
+ }
+
Review comment:
Thanks for adding the test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org