You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/06/04 09:55:48 UTC

[GitHub] [commons-pool] scholzi100 opened a new pull request #31: Added Automatic-Module-Name to support JPMS

scholzi100 opened a new pull request #31:
URL: https://github.com/apache/commons-pool/pull/31


   Adding Automatic-Module-Name provides a standardized way for the JPMS Module-Path.
   This makes discovering commons-pool on the Module-Path standardized and keeps support for non JPMS libraries.
   
   Jira: [POOL-385 ](https://issues.apache.org/jira/browse/POOL-385)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-pool] garydgregory commented on pull request #31: Added Automatic-Module-Name to support JPMS

Posted by GitBox <gi...@apache.org>.

garydgregory commented on pull request #31:
URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638885290


   The name is fine but you should use a property, see Apache Commons Lang for an example.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-pool] garydgregory merged pull request #31: Added Automatic-Module-Name to support JPMS

Posted by GitBox <gi...@apache.org>.

garydgregory merged pull request #31:
URL: https://github.com/apache/commons-pool/pull/31


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-pool] coveralls edited a comment on pull request #31: Added Automatic-Module-Name to support JPMS

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on pull request #31:
URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638776466


   
   [![Coverage Status](https://coveralls.io/builds/31242761/badge)](https://coveralls.io/builds/31242761)
   
   Coverage increased (+0.2%) to 84.246% when pulling **99f921eff44b0bdadcd16b46d40d4dd384cb25ac on scholzi100:POOL-385-Automatic-Module** into **45683c848a241026a9ad04fb5e2494e954593b6a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-pool] coveralls commented on pull request #31: Added Automatic-Module-Name to support JPMS

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #31:
URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638776466


   
   [![Coverage Status](https://coveralls.io/builds/31234653/badge)](https://coveralls.io/builds/31234653)
   
   Coverage increased (+0.07%) to 84.146% when pulling **436a8d9eda0a34e524392956f45ba3eac5ca05fd on scholzi100:POOL-385-Automatic-Module** into **45683c848a241026a9ad04fb5e2494e954593b6a on apache:master**.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-pool] scholzi100 commented on pull request #31: Added Automatic-Module-Name to support JPMS

Posted by GitBox <gi...@apache.org>.

scholzi100 commented on pull request #31:
URL: https://github.com/apache/commons-pool/pull/31#issuecomment-638765667


   @garydgregory can you please review this PR. Is the module name suitable? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org