You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by dongeforever <10...@qq.com> on 2017/04/02 02:16:47 UTC

Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository

Hi Justin:
   No doubt that 
  > The correct URL is:
  > git://git.apache.org/incubator-rocketmq.git <git://git.apache.org/incubator-rocketmq.git>
  > There is a read only mirror on GitHub at:
  > https://github.com/apache/incubator-rocketmq  
  "https://github.com/dongeforever" is just the forked repo, and has been changed as "https://github.com/foo".
  And the blog has been polished with more clear words[1]


  [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/


Regards 
dongeforever


------------------ Original ------------------
From:  "Justin Mclean";<ju...@classsoftware.com>;
Date:  Sun, Apr 2, 2017 10:03 AM
To:  "dev"<de...@rocketmq.incubator.apache.org>; 

Subject:  Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository



Hi,

> https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/
> 
> As the blog describe, people who need send pull request, must fork a
> repository belong to
> 
> https://github.com/dongeforever

That is not the correct URL.

The correct URL is:
git://git.apache.org/incubator-rocketmq.git <git://git.apache.org/incubator-rocketmq.git>

There is a read only mirror on GitHub at:
https://github.com/apache/incubator-rocketmq

Thanks,
Justin

Re: Disagreewith"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"forkorigin repository

Posted by dongeforever <10...@qq.com>.

Hi,
   Thanks for your preciseness. It impressed on me a lot.
   And some polishing is done[1].


[1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/


Regards
dongeforever


------------------ Original ------------------
From:  "Justin Mclean";<ju...@classsoftware.com>;
Date:  Sun, Apr 2, 2017 10:55 AM
To:  "dev"<de...@rocketmq.incubator.apache.org>; 

Subject:  Re: Disagreewith"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"forkorigin repository



Hi,

> [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/

You may want to make it clear that GitHub is a read only mirror of the original git repo at Apache not the original repo.

Thanks,
Justin

Re: Disagree with"https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/"fork origin repository

Posted by Justin Mclean <ju...@classsoftware.com>.

Hi,

> [1] https://rocketmq.apache.org/the-correct-posture-of-submitting-pull-request/

You may want to make it clear that GitHub is a read only mirror of the original git repo at Apache not the original repo.

Thanks,
Justin