You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/10 08:02:20 UTC
[GitHub] [skywalking] kezhenxu94 opened a new pull request #4213: Stop
profiling task when backend doesn't support it
kezhenxu94 opened a new pull request #4213: Stop profiling task when backend doesn't support it
URL: https://github.com/apache/skywalking/pull/4213
When the backend doesn't support profiling task, the agent keep logging exception, this patch just cancel the scheduled task when the backend doesn't support this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 merged pull request #4213: Stop profiling
task when backend doesn't support it
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #4213: Stop profiling task when backend doesn't support it
URL: https://github.com/apache/skywalking/pull/4213
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on issue #4213: Stop profiling
task when backend doesn't support it
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #4213: Stop profiling task when backend doesn't support it
URL: https://github.com/apache/skywalking/pull/4213#issuecomment-572920642
FYI @mrproliu
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io commented on issue #4213: Stop profiling
task when backend doesn't support it
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4213: Stop profiling task when backend doesn't support it
URL: https://github.com/apache/skywalking/pull/4213#issuecomment-572977166
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=h1) Report
> Merging [#4213](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/298b36af1f6083dae6f18d01c561935b28c84ab5?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4213 +/- ##
=======================================
Coverage 26.46% 26.46%
=======================================
Files 1178 1178
Lines 25773 25773
Branches 3748 3748
=======================================
Hits 6822 6822
Misses 18338 18338
Partials 613 613
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=footer). Last update [298b36a...e263926](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] codecov-io edited a comment on issue #4213: Stop
profiling task when backend doesn't support it
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4213: Stop profiling task when backend doesn't support it
URL: https://github.com/apache/skywalking/pull/4213#issuecomment-572977166
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=h1) Report
> Merging [#4213](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/298b36af1f6083dae6f18d01c561935b28c84ab5?src=pr&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4213 +/- ##
==========================================
+ Coverage 26.46% 26.55% +0.08%
==========================================
Files 1178 1178
Lines 25773 25773
Branches 3748 3748
==========================================
+ Hits 6822 6845 +23
+ Misses 18338 18316 -22
+ Partials 613 612 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...m/agent/core/remote/TraceSegmentServiceClient.java](https://codecov.io/gh/apache/skywalking/pull/4213/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1RyYWNlU2VnbWVudFNlcnZpY2VDbGllbnQuamF2YQ==) | `82.35% <0%> (+1.47%)` | :arrow_up: |
| [.../core/remote/ServiceAndEndpointRegisterClient.java](https://codecov.io/gh/apache/skywalking/pull/4213/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VBbmRFbmRwb2ludFJlZ2lzdGVyQ2xpZW50LmphdmE=) | `31.46% <0%> (+3.37%)` | :arrow_up: |
| [...pm/agent/core/profile/ProfileTaskQueryService.java](https://codecov.io/gh/apache/skywalking/pull/4213/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza1F1ZXJ5U2VydmljZS5qYXZh) | `51.28% <0%> (+7.69%)` | :arrow_up: |
| [...alking/apm/agent/core/remote/AgentIDDecorator.java](https://codecov.io/gh/apache/skywalking/pull/4213/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0FnZW50SUREZWNvcmF0b3IuamF2YQ==) | `85.71% <0%> (+17.85%)` | :arrow_up: |
| [...ache/skywalking/apm/agent/core/jvm/JVMService.java](https://codecov.io/gh/apache/skywalking/pull/4213/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTVNlcnZpY2UuamF2YQ==) | `77.04% <0%> (+18.03%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=footer). Last update [298b36a...e263926](https://codecov.io/gh/apache/skywalking/pull/4213?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services