You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2019/09/30 07:55:57 UTC

[GitHub] [incubator-doris] imay commented on issue #1865: Support specifying inverted index columns when creating table for segment V2

imay commented on issue #1865: Support specifying inverted index columns when creating table for segment V2
URL: https://github.com/apache/incubator-doris/issues/1865#issuecomment-536447776
 
 
   @wubiaoi 
   
   First, I'm very sorry to reply so late that your PR has been commit.
   I have some question about this interface. 
   
   1. Why not we use the syntax like MySQL do? Now you put "inverted_index_columns" in properties, if we add some more options to it, it will be more difficult to parse and difficult to user to use it. Such as we support more index type, and more options for each type of index, or we support index multiple columns in one index.
   2. You should propose `CREATE INDEX` and `DROP INDEX` syntax together. Because some of indices are created when they are needed. And then we should have an index name for each index, however if we create index in your way, user don't know index name explicitly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org