You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2016/11/28 06:19:03 UTC

Review Request 54111: Removed unused Socket from Encoder.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54111/
-----------------------------------------------------------

Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Removed unused Socket from Encoder.


Diffs
-----

  3rdparty/libprocess/src/encoder.hpp 515821acb20d2a09d10781af17dcac472a7c117a 
  3rdparty/libprocess/src/process.cpp e9a4bbb0b2410e0260d120b97e73972c94eb0f26 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 5f84d84dc8ff5e1f2684da14d30c1866ad8562d5 

Diff: https://reviews.apache.org/r/54111/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 54111: Removed unused Socket from Encoder.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54111/
-----------------------------------------------------------

(Updated Nov. 29, 2016, 8:23 p.m.)


Review request for mesos and Benjamin Mahler.


Repository: mesos


Description
-------

Removed unused Socket from Encoder.


Diffs (updated)
-----

  3rdparty/libprocess/src/encoder.hpp 515821acb20d2a09d10781af17dcac472a7c117a 
  3rdparty/libprocess/src/process.cpp e9a4bbb0b2410e0260d120b97e73972c94eb0f26 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 5f84d84dc8ff5e1f2684da14d30c1866ad8562d5 

Diff: https://reviews.apache.org/r/54111/diff/


Testing
-------

make check


Thanks,

Benjamin Hindman

Re: Review Request 54111: Removed unused Socket from Encoder.

Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54111/#review157185
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/src/tests/decoder_tests.cpp 
<https://reviews.apache.org/r/54111/#comment227619>

    This seems unrelated? Maybe pull out the socket.hpp include from decoder_tests.cpp and encoder_tests.cpp in a small patch separately?


- Benjamin Mahler


On Nov. 28, 2016, 6:19 a.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54111/
> -----------------------------------------------------------
> 
> (Updated Nov. 28, 2016, 6:19 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed unused Socket from Encoder.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/encoder.hpp 515821acb20d2a09d10781af17dcac472a7c117a 
>   3rdparty/libprocess/src/process.cpp e9a4bbb0b2410e0260d120b97e73972c94eb0f26 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp 5f84d84dc8ff5e1f2684da14d30c1866ad8562d5 
> 
> Diff: https://reviews.apache.org/r/54111/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>