You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Olivier Lamy (JIRA)" <ji...@codehaus.org> on 2008/08/10 01:06:26 UTC

[jira] Created: (SCM-396) git provider implements scm update

git provider implements scm update 
-----------------------------------

                 Key: SCM-396
                 URL: http://jira.codehaus.org/browse/SCM-396
             Project: Maven SCM
          Issue Type: New Feature
          Components: maven-scm-provider-git
            Reporter: Olivier Lamy
             Fix For: 1.1




-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-396) git provider implements scm update

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mark Struberg updated SCM-396:
------------------------------

    Attachment: GitExeUpdateTck.patch

GitExeUpdateTck.patch enables the standard TCK for updates. The parts in maven-scm-provider-gittest has already been there in my original implementation.

Please do NOT apply this TCK in the Apache production repo, since it will fail currently!

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>         Attachments: GitExeUpdateTck.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Reopened: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy reopened SCM-396:
------------------------------


reopen due to Mark comments.

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>         Attachments: GitExeUpdateTck.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=144628#action_144628 ] 

Olivier Lamy commented on SCM-396:
----------------------------------

partially implemented in rev 684464.
TODO finish correct implementation of ScmFileStatus.

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy updated SCM-396:
-----------------------------

         Assignee: Olivier Lamy
    Fix Version/s: 1.1

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-396) git provider implements scm update

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145282#action_145282 ] 

Mark Struberg commented on SCM-396:
-----------------------------------

I'd like to reopen this issue, since the update TCK fails with a 
"The changed files list is empty"
 at org.apache.maven.scm.tck.command.update.UpdateCommandTckTest.testUpdateCommand(UpdateCommandTckTest.java:143)
on my systems.

I'll attach the TCK activation as patch.

It seems that you got a different git-pull output then I usually get. I use a few linux, mac and win boxes and do not get those ' &#8592;[' thingy anywhere. Which environment are you using?
A few example output from my system for further brainstorming:
from your test repo u used
{noformat}
Updating a2a2d2f..ce192c6
Fast forward
 olamy.test |    1 +
 pom.xml    |    9 ++++-----
 test.txt   |    2 +-
 3 files changed, 6 insertions(+), 6 deletions(-)
git-pull-out.txt (END) 
{noformat}

and from another OOS project  (truncated)
{noformat}
Updating dbc7057..da7b9e9
Fast forward
 Makefile.am                      |    6 +-
 README                           |   13 +-
 autogen.sh                       |    1 +
 configure.ac                     |   11 +-
 git_version.sh                   |   47 +-
 man/radeonhd.man                 |  109 +-
 src/Imakefile                    |   29 +-
 src/Makefile.am                  |   67 +-
 src/r5xx_accel.c                 |  210 +-
 src/r5xx_accel.h                 |   34 +-
 src/r5xx_exa.c                   |  215 +-
...
 src/rhd_regs.h                   |   24 +-
 src/rhd_tmds.c                   |    7 +-
 src/rhd_vga.c                    |    4 +-
 utils/conntest/rhd_conntest.c    |  153 +-
 66 files changed, 23799 insertions(+), 2124 deletions(-)
 create mode 100644 src/radeon_accel.c
 create mode 100644 src/radeon_accel.h
 create mode 100644 src/radeon_accelfuncs.c
 create mode 100644 src/radeon_commonfuncs.c
 create mode 100644 src/radeon_drm.h
...
{noformat}

Also the update command currently only works on the branch 'master' which is comparable to 'trunk' in SVN. So this will fail if we are working on a 'real' branch.

Btw: you may test git-pull easily if you perform
git-reset --hard a2a2d2f5d2ec3f    (this will reset your HEAD to the old commit a2a2d2...)
git-gc   (this will really erase all unused commit blobs in your .git directory)
afterwards you may git-pull again to reproduce a parseable output.

I'll hopefully find time on wednesday to investigate further.

LieGrü,
strub


> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

[jira] Closed: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed SCM-396.
----------------------------

    Resolution: Fixed

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>         Attachments: GitExeUpdateTck.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Closed: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Olivier Lamy closed SCM-396.
----------------------------

    Resolution: Fixed

fixed in rev 684601.

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-396) git provider implements scm update

Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145520#action_145520 ] 

Olivier Lamy commented on SCM-396:
----------------------------------

Mark,
I use cygwin. But the consummer handle the character | too and this should work with your format too.
IMHO,  you can open an other issue with the fix for tck update test and we can close it ?
WDYT ?

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>         Attachments: GitExeUpdateTck.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (SCM-396) git provider implements scm update

Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/SCM-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=145555#action_145555 ] 

Mark Struberg commented on SCM-396:
-----------------------------------

Olivier, this is ok, please close it. 
I've created SCM-403 and SCM-404 for the improvements.

> git provider implements scm update 
> -----------------------------------
>
>                 Key: SCM-396
>                 URL: http://jira.codehaus.org/browse/SCM-396
>             Project: Maven SCM
>          Issue Type: New Feature
>          Components: maven-scm-provider-git
>            Reporter: Olivier Lamy
>            Assignee: Olivier Lamy
>             Fix For: 1.1
>
>         Attachments: GitExeUpdateTck.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira