You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/07 12:40:28 UTC
[GitHub] zentol commented on a change in pull request #7659:
[FLINK-11514][client] Port ClusterClientTest
zentol commented on a change in pull request #7659: [FLINK-11514][client] Port ClusterClientTest
URL: https://github.com/apache/flink/pull/7659#discussion_r254664912
##########
File path: flink-clients/src/test/java/org/apache/flink/client/program/rest/RestClusterClientTest.java
##########
@@ -448,20 +457,24 @@ public void testTriggerSavepoint() throws Exception {
try {
JobID id = new JobID();
{
- CompletableFuture<String> savepointPathFuture = restClusterClient.triggerSavepoint(id, null);
- String savepointPath = savepointPathFuture.get();
+ String savepointPath = cancelJob
Review comment:
We have to test both scenarious (cancel being true and false), as otherwise we wouldn't detect bugs where the flag is _always_ set or parsed to true of false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services