You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2013/08/08 04:06:54 UTC

svn commit: r1511558 - in /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram: RamFileData.java RamFileObject.java

Author: ggregory
Date: Thu Aug  8 02:06:53 2013
New Revision: 1511558

URL: http://svn.apache.org/r1511558
Log:
[VFS-483][RAM] Many suggestions to improve the RAM file provider. Refactor 'new byte[0]' into a private static final byte[] called EMPTY.

Modified:
    commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileData.java
    commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java

Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileData.java
URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileData.java?rev=1511558&r1=1511557&r2=1511558&view=diff
==============================================================================
--- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileData.java (original)
+++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileData.java Thu Aug  8 02:06:53 2013
@@ -30,7 +30,7 @@ import org.apache.commons.vfs2.FileType;
  */
 class RamFileData implements Serializable
 {
-    private static final byte[] EMPTY = new byte[0];
+    static final byte[] EMPTY = new byte[0];
 
     /**
      * serialVersionUID format is YYYYMMDD for the date of the last binary change.

Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java
URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java?rev=1511558&r1=1511557&r2=1511558&view=diff
==============================================================================
--- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java (original)
+++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ram/RamFileObject.java Thu Aug  8 02:06:53 2013
@@ -119,7 +119,7 @@ public class RamFileObject extends Abstr
     {
         if (!bAppend)
         {
-            this.data.setContent(new byte[0]);
+            this.data.setContent(RamFileData.EMPTY);
         }
         return new RamFileOutputStream(this);
     }