You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Gilles (Created) (JIRA)" <ji...@apache.org> on 2011/10/10 23:38:30 UTC
[jira] [Created] (MATH-689) Breaking up "MathUtils"
Breaking up "MathUtils"
-----------------------
Key: MATH-689
URL: https://issues.apache.org/jira/browse/MATH-689
Project: Commons Math
Issue Type: Task
Reporter: Gilles
Priority: Trivial
Fix For: 3.0
Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
There seemed to be a global agreement on the following break-up:
* Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
* Precision (for "equals", "compare", ...)
* Binomial (for "binomialCoefficient")
* MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124541#comment-13124541 ]
Gilles commented on MATH-689:
-----------------------------
bq. I'm going to move the functions to the "Precision" class.
Done in revision 1181282.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135524#comment-13135524 ]
Gilles commented on MATH-689:
-----------------------------
"Arithmetics" is advantageously shorter than "ArithmeticUtils". Adding a "Utils" suffix to the name of a class that belongs to a package "util" seems unnecessary.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Sébastien Brisard (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126494#comment-13126494 ]
Sébastien Brisard commented on MATH-689:
----------------------------------------
{quote}
Can we change "ArithmeticsUtils" to "ArithmeticUtils."
{quote}
Sure. Done in rev 1182787. I forgot to set an entry log for this rev, and do not know if it's possible to do it now.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Sébastien Brisard (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124883#comment-13124883 ]
Sébastien Brisard commented on MATH-689:
----------------------------------------
OK, I'll work on {{Arithmetics}}.
Sébastien
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Phil Steitz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126356#comment-13126356 ]
Phil Steitz commented on MATH-689:
----------------------------------
Sorry I missed this before. Can we change "ArithmeticsUtils" to "ArithmeticUtils."
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125447#comment-13125447 ]
Gilles commented on MATH-689:
-----------------------------
I'll do "MathArrays".
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135439#comment-13135439 ]
Gilles commented on MATH-689:
-----------------------------
"round" methods moved to "Precision" (revision 1188915).
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136928#comment-13136928 ]
Gilles commented on MATH-689:
-----------------------------
Constants moved in r1189593 (commit done by Phil, because of a problem with svn).
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles resolved MATH-689.
-------------------------
Resolution: Fixed
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135832#comment-13135832 ]
Gilles commented on MATH-689:
-----------------------------
I've no strong feelings, but I feel a little sorry that only these two little "double" functions are left alone in "MathUtils"...
Do you have an objection to my other suggestions (about the constants and "indicator")?
I also propose to move the "pow" (of an integer) functions to "Arithmetic[Util]s".
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125462#comment-13125462 ]
Gilles commented on MATH-689:
-----------------------------
bq. I'll do "MathArrays".
Done in revision 1182134.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124880#comment-13124880 ]
Gilles commented on MATH-689:
-----------------------------
Bonjour Sébastien.
[Je réponds en direct parce le site "issues.apache.org" semble inaccessible
pour le moment.]
Choisis celui qui te fait le plus plaisir ;-}. ["Precision" a été fait.]
Bonne journée,
Gilles
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Luc Maisonobe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135744#comment-13135744 ]
Luc Maisonobe commented on MATH-689:
------------------------------------
I don't agree with moving reduce and normalizeAngle. They are specific dedicated functions that are not present in Math/StrictMath and are not close enough to existing functions to be merged (which is the reason why inverse hyperbolic functions for examples are in FastMath despite they are not in Math/StrictMath).
+1 For Arithmetics.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Sébastien Brisard (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124731#comment-13124731 ]
Sébastien Brisard commented on MATH-689:
----------------------------------------
Happy to help. Just let me know which part you would like me to work on.
Sébastien
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Luc Maisonobe (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135841#comment-13135841 ]
Luc Maisonobe commented on MATH-689:
------------------------------------
Then MathUtils is less bloated, so its good. I don't think we want to remove completely MathUtils.
Moving the constants and indicator functions is a good idea.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MATH-689) Breaking up "MathUtils"
Posted by "Sébastien Brisard (Issue Comment Edited JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125618#comment-13125618 ]
Sébastien Brisard edited comment on MATH-689 at 10/13/11 5:30 AM:
------------------------------------------------------------------
{{ArithmeticsUtils}} TODO list
(/) {{addAndCheck(int x, int y)}}: done in rev r1182213
(/) {{addAndCheck(long a, long b)}}: done in rev r1182213
(/) {{binomialCoefficient(int n, int k)}}: done in rev r1182658
(/) {{binomialCoefficientDouble(int n, int k)}}: done in rev r1182658
(/) {{binomialCoefficientLog(int n, int k)}}: done in rev r1182658
(/) {{factorial(int n)}}: done in rev r1182213
(/) {{factorialDouble(int n)}}: done in rev r1182213
(/) {{factorialLog(int n)}}: done in rev r1182213
(/) {{gcd(int p, int q)}}: done in rev r1182213
(/) {{gcd(long p, long q)}}: done in rev r1182213
(/) {{lcm(int a, int b)}}: done in rev r1182658
(/) {{lcm(long a, long b)}}: done in rev r1182658
(/) {{mulAndCheck(int x, int y)}}: done in rev r1182658
(/) {{mulAndCheck(long a, long b)}}: done in rev r1182658
(/) {{subAndCheck(int x, int y)}}: done in rev r1182213
(/) {{subAndCheck(long a, long b)}}: done in rev r1182213
was (Author: celestin):
{{ArithmeticsUtils}} TODO list
(/) {{addAndCheck(int x, int y)}}: done in rev r1182213
(/) {{addAndCheck(long a, long b)}}: done in rev r1182213
(x) {{binomialCoefficient(int n, int k)}}
(x) {{binomialCoefficientDouble(int n, int k)}}
(x) {{binomialCoefficientLog(int n, int k)}}
(/) {{factorial(int n)}}: done in rev r1182213
(/) {{factorialDouble(int n)}}: done in rev r1182213
(/) {{factorialLog(int n)}}: done in rev r1182213
(/) {{gcd(int p, int q)}}: done in rev r1182213
(/) {{gcd(long p, long q)}}: done in rev r1182213
(x) {{lcm(int a, int b)}}
(x) {{lcm(long a, long b)}}
(x) {{mulAndCheck(int x, int y)}}
(x) {{mulAndCheck(long a, long b)}}
(/) {{subAndCheck(int x, int y)}}: done in rev r1182213
(/) {{subAndCheck(long a, long b)}}: done in rev r1182213
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157178#comment-13157178 ]
Gilles commented on MATH-689:
-----------------------------
"pow" functions moved in r1206199.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135510#comment-13135510 ]
Gilles commented on MATH-689:
-----------------------------
* OK to move "reduce" and "normalizeAngle" over to "FastMath"?
* OK to move the constants "EPSILON" and "SAFE_MIN" over to "Precision"?
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124499#comment-13124499 ]
Gilles commented on MATH-689:
-----------------------------
I'm going to move the functions to the "Precision" class.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Sébastien Brisard (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125618#comment-13125618 ]
Sébastien Brisard commented on MATH-689:
----------------------------------------
{{ArithmeticsUtils}} TODO list
(/) {{addAndCheck(int x, int y)}}: done in rev r1182213
(/) {{addAndCheck(long a, long b)}}: done in rev r1182213
(x) {{binomialCoefficient(int n, int k)}}
(x) {{binomialCoefficientDouble(int n, int k)}}
(x) {{binomialCoefficientLog(int n, int k)}}
(/) {{factorial(int n)}}: done in rev r1182213
(/) {{factorialDouble(int n)}}: done in rev r1182213
(/) {{factorialLog(int n)}}: done in rev r1182213
(/) {{gcd(int p, int q)}}: done in rev r1182213
(/) {{gcd(long p, long q)}}: done in rev r1182213
(x) {{lcm(int a, int b)}}
(x) {{lcm(long a, long b)}}
(x) {{mulAndCheck(int x, int y)}}
(x) {{mulAndCheck(long a, long b)}}
(/) {{subAndCheck(int x, int y)}}: done in rev r1182213
(/) {{subAndCheck(long a, long b)}}: done in rev r1182213
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135499#comment-13135499 ]
Gilles commented on MATH-689:
-----------------------------
"log(double base, double x)" moved to "FastMath" (revision 1188949).
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125462#comment-13125462 ]
Gilles edited comment on MATH-689 at 10/11/11 11:38 PM:
--------------------------------------------------------
bq. I'll do "MathArrays".
Done in revisions 1182134, 1182137, 1182147.
was (Author: erans):
bq. I'll do "MathArrays".
Done in revision 1182134.
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MATH-689) Breaking up "MathUtils"
Posted by "Gilles (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MATH-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gilles updated MATH-689:
------------------------
Comment: was deleted
(was: Bonjour Sébastien.
[Je réponds en direct parce le site "issues.apache.org" semble inaccessible
pour le moment.]
Choisis celui qui te fait le plus plaisir ;-}. ["Precision" a été fait.]
Bonne journée,
Gilles
)
> Breaking up "MathUtils"
> -----------------------
>
> Key: MATH-689
> URL: https://issues.apache.org/jira/browse/MATH-689
> Project: Commons Math
> Issue Type: Task
> Reporter: Gilles
> Priority: Trivial
> Labels: api-change
> Fix For: 3.0
>
>
> Issue related to this [proposal|http://www.mail-archive.com/dev@commons.apache.org/msg25617.html].
> There seemed to be a global agreement on the following break-up:
> * Arithmetics (for "addAndCheck", "factorial", "gcd", ...)
> * Precision (for "equals", "compare", ...)
> * Binomial (for "binomialCoefficient")
> * MathArrays (for "linearCombination", "distance", "safeNorm", "sortInPlace", "copyOf", ...)
> I think that "ordinary" mathematical functions ("pow", "cosh", ...) should go into "FastMath" (if not already available there).
> Those who are willing to work on this issue, please coordinate here.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira