[GitHub] mistercrunch commented on a change in pull request #5521: Adding 364 days to time compare option

[GitBox <gi...@apache.org>]

mistercrunch commented on a change in pull request #5521: Adding 364 days to time compare option
URL: https://github.com/apache/incubator-superset/pull/5521#discussion_r206408011
 
 

 ##########
 File path: superset/assets/src/explore/controls.jsx
 ##########
 @@ -1561,6 +1561,7 @@ export const controls = {
       '1 week',
       '28 days',
       '30 days',
+      '364 days',
 
 Review comment:
   I also think 52 weeks conveys the "same day of week" idea better.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org