You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Linus Tseng (JIRA)" <ji...@apache.org> on 2008/06/07 05:28:45 UTC

[jira] Created: (WICKET-1687) LinkTree can't trigger the onNodeLinkClicked

LinkTree can't trigger the onNodeLinkClicked
--------------------------------------------

                 Key: WICKET-1687
                 URL: https://issues.apache.org/jira/browse/WICKET-1687
             Project: Wicket
          Issue Type: Bug
          Components: wicket
    Affects Versions: 1.4-M2
         Environment: Normal Environment
            Reporter: Linus Tseng
            Priority: Critical


Because  LinkIconPanel.onNodeLinkClicked was changed the parameter from 
(TreeNode node, BaseTree tree, AjaxRequestTarget target) to (Object node, BaseTree tree, AjaxRequestTarget target)

the code
	return new LinkIconPanel(id, model, LinkTree.this)
		{
			private static final long serialVersionUID = 1L;

			protected void onNodeLinkClicked(<b>TreeNode node</b>, BaseTree tree, AjaxRequestTarget target)
			{
				super.onNodeLinkClicked(node, tree, target);
				LinkTree.this.onNodeLinkClicked(node, tree, target);
}
		};
won't  call the LinkTree.this.onNodeLinkClicked(node, tree, target);
it would be better change the code to 

		protected void onNodeLinkClicked(<br>Object</b> node, BaseTree tree, AjaxRequestTarget target)
			{
				super.onNodeLinkClicked(node, tree, target);
				LinkTree.this.onNodeLinkClicked(<b>(TreeNode)node</b>, tree, target);
			}

and it will work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-1687) LinkTree can't trigger the onNodeLinkClicked

Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12658151#action_12658151 ] 

Juergen Donnerstag commented on WICKET-1687:
--------------------------------------------

I don't understand ?!?

LinkTree.java
	protected void onNodeLinkClicked(Object node, BaseTree tree, AjaxRequestTarget target)
	{
	}

How will your sugestion change anything?

> LinkTree can't trigger the onNodeLinkClicked
> --------------------------------------------
>
>                 Key: WICKET-1687
>                 URL: https://issues.apache.org/jira/browse/WICKET-1687
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-M2
>         Environment: Normal Environment
>            Reporter: Linus Tseng
>            Priority: Critical
>
> Because  LinkIconPanel.onNodeLinkClicked was changed the parameter from 
> (TreeNode node, BaseTree tree, AjaxRequestTarget target) to (Object node, BaseTree tree, AjaxRequestTarget target)
> the code
> 	return new LinkIconPanel(id, model, LinkTree.this)
> 		{
> 			private static final long serialVersionUID = 1L;
> 			protected void onNodeLinkClicked(<b>TreeNode node</b>, BaseTree tree, AjaxRequestTarget target)
> 			{
> 				super.onNodeLinkClicked(node, tree, target);
> 				LinkTree.this.onNodeLinkClicked(node, tree, target);
> }
> 		};
> won't  call the LinkTree.this.onNodeLinkClicked(node, tree, target);
> it would be better change the code to 
> 		protected void onNodeLinkClicked(<br>Object</b> node, BaseTree tree, AjaxRequestTarget target)
> 			{
> 				super.onNodeLinkClicked(node, tree, target);
> 				LinkTree.this.onNodeLinkClicked(<b>(TreeNode)node</b>, tree, target);
> 			}
> and it will work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WICKET-1687) LinkTree can't trigger the onNodeLinkClicked

Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-1687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Igor Vaynberg resolved WICKET-1687.
-----------------------------------

    Resolution: Won't Fix

closing until more details are provided

> LinkTree can't trigger the onNodeLinkClicked
> --------------------------------------------
>
>                 Key: WICKET-1687
>                 URL: https://issues.apache.org/jira/browse/WICKET-1687
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4-M2
>         Environment: Normal Environment
>            Reporter: Linus Tseng
>            Priority: Critical
>
> Because  LinkIconPanel.onNodeLinkClicked was changed the parameter from 
> (TreeNode node, BaseTree tree, AjaxRequestTarget target) to (Object node, BaseTree tree, AjaxRequestTarget target)
> the code
> 	return new LinkIconPanel(id, model, LinkTree.this)
> 		{
> 			private static final long serialVersionUID = 1L;
> 			protected void onNodeLinkClicked(<b>TreeNode node</b>, BaseTree tree, AjaxRequestTarget target)
> 			{
> 				super.onNodeLinkClicked(node, tree, target);
> 				LinkTree.this.onNodeLinkClicked(node, tree, target);
> }
> 		};
> won't  call the LinkTree.this.onNodeLinkClicked(node, tree, target);
> it would be better change the code to 
> 		protected void onNodeLinkClicked(<br>Object</b> node, BaseTree tree, AjaxRequestTarget target)
> 			{
> 				super.onNodeLinkClicked(node, tree, target);
> 				LinkTree.this.onNodeLinkClicked(<b>(TreeNode)node</b>, tree, target);
> 			}
> and it will work

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.