You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/08 22:06:23 UTC
[GitHub] [druid] mghosh4 opened a new pull request #10368: Adding the missing sqlQueryContext api
mghosh4 opened a new pull request #10368:
URL: https://github.com/apache/druid/pull/10368
Fixes #10367.
### Description
Adding the missing sqlQueryContext api
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] clintropolis merged pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
clintropolis merged pull request #10368:
URL: https://github.com/apache/druid/pull/10368
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690618923
BTW, I tagged "Release Notes" and "Design Review" since this PR modifies a Public API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mghosh4 commented on pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
mghosh4 commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690905081
> Hi @mghosh4, the code change looks good to me, but I think it would be nice to have some test for this class. Would you mind adding one which verifies JSON-serialization? We don't currently have any tests for `DefaultRequestLogEvent`, so you may want to add one.
Added the test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mghosh4 commented on pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
mghosh4 commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690905081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690618493
Hi @mghosh4, the code change looks good to me, but I think it would be nice to have some test for this class. Would you mind adding one which verifies JSON-serialization? We don't currently have any tests for `DefaultRequestLogEvent`, so you may want to add one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] mghosh4 commented on pull request #10368: Adding the missing sqlQueryContext api
Posted by GitBox <gi...@apache.org>.
mghosh4 commented on pull request #10368:
URL: https://github.com/apache/druid/pull/10368#issuecomment-690905081
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org