[GitHub] [incubator-doris] morningman commented on a change in pull request #3713: Use BackendStatus to show BE's infomation in `show backends;`

[GitBox <gi...@apache.org>]

morningman commented on a change in pull request #3713:
URL: https://github.com/apache/incubator-doris/pull/3713#discussion_r433857519



##########
File path: fe/src/main/java/org/apache/doris/master/ReportHandler.java
##########
@@ -247,6 +249,13 @@ private static void tabletReport(long backendId, Map<Long, TTablet> backendTable
         LOG.info("backend[{}] reports {} tablet(s). report version: {}",
                  backendId, backendTablets.size(), backendReportVersion);
 
+        final SystemInfoService currentSystemInfo = Catalog.getCurrentSystemInfo();
+        Backend reportBackend = currentSystemInfo.getBackend(backendId);
+        if (reportBackend != null) {
+            BackendStatus backendStatus = reportBackend.getBackendStatus();
+            backendStatus.lastTabletReportTime = TimeUtils.longToTimeString(start);

Review comment:
       It ok, not a big deal.
   Oh, I suggest to set this value right after the report in done, in case some other error happens during the report process.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org