You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Lin Sun (JIRA)" <ji...@apache.org> on 2008/09/23 17:21:46 UTC
[jira] Created: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
All the plugins are marked as installable on the install plugins portlet
------------------------------------------------------------------------
Key: GERONIMO-4318
URL: https://issues.apache.org/jira/browse/GERONIMO-4318
Project: Geronimo
Issue Type: Bug
Security Level: public (Regular issues)
Components: console
Affects Versions: 2.2
Reporter: Lin Sun
Assignee: Lin Sun
Fix For: 2.2
All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634779#action_12634779 ]
David Jencks commented on GERONIMO-4318:
----------------------------------------
I added some tracking for plugins installed into a particular server in rev 699202, but didn't test the effects on the console. The change doesn't appear to cause the problems seen with the previous attempt.
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12634937#action_12634937 ]
David Jencks commented on GERONIMO-4318:
----------------------------------------
rev 699420 fixes these problems Lin noticed:
-- c-m-p InstallModulesMojo needs to actually track the installed plugins
-- plugin plugin PluginInstallerGBean needs to be configured with the tracking file location
-- bug in save method in PluginInstallerGBean
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun resolved GERONIMO-4318.
-------------------------------
Resolution: Fixed
This is fixed by rev698248. Tested with the install plugin portlet.
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635403#action_12635403 ]
Lin Sun commented on GERONIMO-4318:
-----------------------------------
David,
I have tested the changes you made. Looks good on the portlets. There is a minor issue with install .car file, when installing a .car file onto a server that already has the plugin, as we don't notify the user that the plugin is already existed. I am proposing the following change to fix that, hopefully this would not interfere with your farming stuff. let me know.
Index: framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java
===================================================================
--- framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java (revision 699439)
+++ framework/modules/geronimo-plugin/src/main/java/org/apache/geronimo/system/plugin/PluginInstallerGBean.java (working copy)
@@ -932,7 +932,7 @@
// 2. Validate that we can install this
if (!validatePlugin(data)) {
//already installed
- return;
+ throw new MissingDependencyException("Already installed", toArtifact(data.getPluginArtifact().get(0).getModuleId()), (Stack<Artifact>)null);
}
Also, I'd like to replace the MissingDependencyException to ConfigAlreadyExistException due to this JIRA - GERONIMO-4230. Any issue with that?
Lin
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun updated GERONIMO-4318:
------------------------------
Attachment: G4318.patch
Sorry it was not formatted nicely in previous comment, so attaching a file here.
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
> Attachments: G4318.patch
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "Lin Sun (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lin Sun resolved GERONIMO-4318.
-------------------------------
Resolution: Fixed
See subversion commits. Many thanks to David Jencks for making changes that work for the farm scenario.
Currently plugin groups and regular plugins (that are added to the config) are all tracked correctly. There are one minor issue:
plugin that doesn't get added to configuration, such as boilerplate and jaxws-tools are marked as installable even if they are already installed. I am not sure the best way to solve this (is there an easy way to detect these type of geronimo plugins? I know for c-m-p it is easy as it just detect if it has plan.xml file).
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
> Attachments: G4318.patch
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (GERONIMO-4318) All the plugins are marked as
installable on the install plugins portlet
Posted by "David Jencks (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-4318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Jencks reopened GERONIMO-4318:
------------------------------------
The change you reverted is essential to allow multiple servers that use the same repository to all be able to install a plugin. Checking the repo for whether a plugin is present is not an indication whether it has been installed on the current server. If the plugin is not in any repo, then surely it hasn't been installed, but just because it is in the repo does not mean it has gone through installation which results typically in mention in some config.xml files, copying files into var, etc etc.
I'm going to revert your change as it breaks the plugin farm functionality.
> All the plugins are marked as installable on the install plugins portlet
> ------------------------------------------------------------------------
>
> Key: GERONIMO-4318
> URL: https://issues.apache.org/jira/browse/GERONIMO-4318
> Project: Geronimo
> Issue Type: Bug
> Security Level: public(Regular issues)
> Components: console
> Affects Versions: 2.2
> Reporter: Lin Sun
> Assignee: Lin Sun
> Fix For: 2.2
>
>
> All the plugins are marked as installable on the install plugins portlet. We check if a plugin is installable by using pluginInstaller.validatePlugin. If an exception is thrown, then we set the installable to false. The throw of MissingDependencyException in validatePlugin method is commented out during rev 696105.
> A proposed fix is to throw ConfigurationAlreadyExistsException when validatePlugin fails because of the configuration is already installed. This seems more reasonable and will also get rid of the confusion message of "Missing Dependency: XXX" when a user attempts to install a plugin that has already been installed using the "deploy install-plugin" command.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.