You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/01/11 13:17:16 UTC

[GitHub] [calcite] devozerov commented on pull request #2323: [CALCITE-4461] Do not use `Logical` nodes inside Enumerable rules

devozerov commented on pull request #2323:
URL: https://github.com/apache/calcite/pull/2323#issuecomment-757944915


   @vlsi regarding testing, I agree that it would be great to have tests here. However, possible options, like manual testing on a per-rule basis, or an additional library, look pretty heavy-weight to me comparing to the scope of changes. Another thing is that some rules already worked with non-Logical classes before this change.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org