You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Xi Wang <xw...@hortonworks.com> on 2017/02/24 00:35:40 UTC
Review Request 57008: Side Nav: multiple fixes after integrated to
trunk
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57008/
-----------------------------------------------------------
Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
Bugs: AMBARI-20160
https://issues.apache.org/jira/browse/AMBARI-20160
Repository: ambari
Description
-------
Need to fix the following issues after integrated the Side Navi Bar and Top Bar to trunk:
1. Service actions dropdown might positioned incorrectly sometimes.
2. If the scrollbar shows up, sometimes it is on top of the actions dropdown menu.
3. Alerts Panel: change alert definition name into 14px in #333
4. Remove menu on Admin page, it is duplicated
5. Alerts Panel: red alerts cnt circle should be able to display large numbers. eg 99, 999, 9999 .etc
6. FireFox issue: alert description not limited. should be limited to 3 lines
Diffs
-----
ambari-web/app/styles/application.less cb94a54
ambari-web/app/styles/theme/bootstrap-ambari.css d88a1ed
ambari-web/app/styles/top-nav.less 8c373ce
ambari-web/app/templates/main/admin.hbs d1dfe74
ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1c81aeb
Diff: https://reviews.apache.org/r/57008/diff/
Testing
-------
20375 passing (37s)
153 pending
Thanks,
Xi Wang
Re: Review Request 57008: Side Nav: multiple fixes after integrated
to trunk
Posted by Richard Zang <rz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57008/#review166628
-----------------------------------------------------------
Ship it!
Ship It!
- Richard Zang
On Feb. 24, 2017, 12:35 a.m., Xi Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57008/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2017, 12:35 a.m.)
>
>
> Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako.
>
>
> Bugs: AMBARI-20160
> https://issues.apache.org/jira/browse/AMBARI-20160
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Need to fix the following issues after integrated the Side Navi Bar and Top Bar to trunk:
> 1. Service actions dropdown might positioned incorrectly sometimes.
> 2. If the scrollbar shows up, sometimes it is on top of the actions dropdown menu.
> 3. Alerts Panel: change alert definition name into 14px in #333
> 4. Remove menu on Admin page, it is duplicated
> 5. Alerts Panel: red alerts cnt circle should be able to display large numbers. eg 99, 999, 9999 .etc
> 6. FireFox issue: alert description not limited. should be limited to 3 lines
>
>
> Diffs
> -----
>
> ambari-web/app/styles/application.less cb94a54
> ambari-web/app/styles/theme/bootstrap-ambari.css d88a1ed
> ambari-web/app/styles/top-nav.less 8c373ce
> ambari-web/app/templates/main/admin.hbs d1dfe74
> ambari-web/vendor/scripts/theme/bootstrap-ambari.js 1c81aeb
>
> Diff: https://reviews.apache.org/r/57008/diff/
>
>
> Testing
> -------
>
> 20375 passing (37s)
> 153 pending
>
>
> Thanks,
>
> Xi Wang
>
>