You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "slyubomirsky (via GitHub)" <gi...@apache.org> on 2023/06/27 18:06:50 UTC
[GitHub] [tvm] slyubomirsky opened a new pull request, #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
slyubomirsky opened a new pull request, #15170:
URL: https://github.com/apache/tvm/pull/15170
A small follow-up to #15140, which was merged before I could make this addition: This change throws an error if a function has been annotated as private but the user manually specifies the global symbol. Since it is a contradiction to do so, it is best to detect this error rather than have it silently work (with the effect of actually making the function public).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1609993143
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "slyubomirsky (via GitHub)" <gi...@apache.org>.
slyubomirsky commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1610098839
Having syntax sugar for global symbol might make sense. However, as established in the last PR, I think we would prefer for the default not to be private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1610078509
This is a really cool addition! A bit off the topic: do you think we should sugar the `global_symbol` attribute to make it part of the decorator? For example,
```
@R.function(global_symbol=True) # implies the global symbol name as "my_relax_func"
def my_relax_func: ...
@I.prim_func(global_symbol=True) # implies the global symbol name as "my_relax_func"
def my_tir_func: ...
@I.prim_func # implies the private symbol
def my_private_func: ...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky merged pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "slyubomirsky (via GitHub)" <gi...@apache.org>.
slyubomirsky merged PR #15170:
URL: https://github.com/apache/tvm/pull/15170
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1610303032
in fact default not being private sounds better to me :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "tqchen (via GitHub)" <gi...@apache.org>.
tqchen commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1610303810
I agree, we would go for default not private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15170: [Unity][UX][Tweak] Make it an error to mark a function private and specify a global symbol
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15170:
URL: https://github.com/apache/tvm/pull/15170#issuecomment-1609993139
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org