You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 15:37:18 UTC

[GitHub] [arrow] jorisvandenbossche commented on pull request #10520: ARROW-12709: [C++] Add var_args_join

jorisvandenbossche commented on pull request #10520:
URL: https://github.com/apache/arrow/pull/10520#issuecomment-860784051


   Some naming nitpicks ;) 
   I think "var_args_join" is not super clear. Having a notion about it being for string data would be good, and the scalar list of string join kernel that was just added in ARROW-10959 is called "binary_join" (binary because it supports all binary and not just string, which is the same here I think). So something about "binary_join_var_args" ? 
   Another reference is the variadic element-wise min/max kernels that were added, where "element_wise" was used and not "var_args". That would then give something like "binary_join_element_wise" (a mouthful ..)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org