Re: [PR] Introduce MAL/LAL/Hierarchy V2 engine — replace Groovy DSL runtime with ANTLR4 + Javassist [skywalking]

["wu-sheng (via GitHub)" <gi...@apache.org>]

wu-sheng commented on PR #13723:
URL: https://github.com/apache/skywalking/pull/13723#issuecomment-4005549988

   **Gemini Code Review — V2 Engine Migration (Groovy Replacement)**
   
   I have completed a comprehensive review of the changes in the `groovy-replace` branch. The migration from Groovy-based V1 to the ANTLR4/Javassist-based V2 engine is architecturally sound and significantly improves the robustness of the OAP analyzer.
   
   **Key Technical Highlights:**
   * **Concurrency & Thread Safety:** The removal of `ThreadLocal` in favor of explicit context passing (`ExecutionContext`, `RunningContext`) is a major improvement. The generated classes (`MalExpr`, `LalExpr`) are stateless and thread-safe, ensuring predictable behavior under high concurrency.
   * **Feature Parity & Validation:** Strong parity is verified via `MalComparisonTest` and `LalComparisonTest`. The latest fix to fail explicitly on V1 runtime errors during data generation ensures the integrity of the test expectations.
   * **Performance Optimization:** The transition to compiled bytecode (via `LALClassGenerator` and `MALClassGenerator`) eliminates the overhead of dynamic script evaluation, providing a more performant execution path for LAL, MAL, and Hierarchy rules.
   
   The migration successfully modernizes the DSL engine while maintaining strict compatibility with existing rule configurations.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org