You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/13 18:32:17 UTC
[GitHub] [incubator-tvm] wpan11nv opened a new pull request #4876:
[CodeGen][CUDA] Fix issues in cuda codegen
wpan11nv opened a new pull request #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876
- Do not emit __shared__ etc. as part of type for casting
- Fix fp16 reduction kernels with compiler errors:
"no operator "+" matches these operands, volatile half + volatile half
This patch inserts casts to remove volatile type qualifier following
volatile loads (fp16 only). CUDA fp16 library headers should add
volatile member functions.
Signed-off-by: Wei Pan <we...@nvidia.com>
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wpan11nv commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
wpan11nv commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-586550799
Updated the patch as suggested. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 edited a comment on issue #4876:
[CodeGen][CUDA] Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
vinx13 edited a comment on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-586542924
also cc @yzhliu @zxy844288792 @Hzfengsy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-586665603
Thanks @wpan11nv this is merged
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 merged pull request #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
vinx13 merged pull request #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wpan11nv edited a comment on issue #4876:
[CodeGen][CUDA] Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
wpan11nv edited a comment on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-585914125
This patch should fix errors observed below (I did *not* verify as I found no complete reproducers there). My own test works fine with CUDA 10.2.
https://discuss.tvm.ai/t/error-fp16-cuda-compilation-error/4586
This issue has been also reported to NVIDIA CUDA team.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-586542881
We can remove these lines
https://github.com/apache/incubator-tvm/blob/master/src/target/source/codegen_cuda.cc#L60-L73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] wpan11nv commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
wpan11nv commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-585914125
This patch should fix errors observed below (I did *not* verify as I found no complete reproduces there). My own test works fine with CUDA 10.2.
https://discuss.tvm.ai/t/error-fp16-cuda-compilation-error/4586
This issue has been also reported to NVIDIA CUDA team.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] vinx13 commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
vinx13 commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-586542924
also cc @yzhliu @zxy844288792
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-tvm] tqchen commented on issue #4876: [CodeGen][CUDA]
Fix issues in cuda codegen
Posted by GitBox <gi...@apache.org>.
tqchen commented on issue #4876: [CodeGen][CUDA] Fix issues in cuda codegen
URL: https://github.com/apache/incubator-tvm/pull/4876#issuecomment-585924576
cc @vinx13 @ZihengJiang please help to take a look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services