You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 21:15:16 UTC
[GitHub] [arrow] kou commented on a change in pull request #11833: ARROW-14961: [C++] Bump google benchmark version
kou commented on a change in pull request #11833:
URL: https://github.com/apache/arrow/pull/11833#discussion_r761470565
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -463,7 +463,6 @@ if(DEFINED ENV{ARROW_GBENCHMARK_URL})
else()
set_urls(GBENCHMARK_SOURCE_URL
"https://github.com/google/benchmark/archive/${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz"
- "https://github.com/ursa-labs/thirdparty/releases/download/latest/gbenchmark-${ARROW_GBENCHMARK_BUILD_VERSION}.tar.gz"
Review comment:
How about using https://apache.jfrog.io/ instead of https://github.com/ursa-labs/thirdparty/ such as https://apache.jfrog.io/artifactory/arrow/boost/1.73.0/boost_1_73_0.tar.bz2 ?
1. If GitHub is down, all mirrors aren't available.
2. https://apache.jfrog.io/ is a ASF resource but https://github.com/ursa-labs/thirdparty/ isn't a ASF resource.
We can use https://apache.jfrog.io/ with our ASF account.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org