You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/04/02 03:53:34 UTC

[GitHub] [pulsar] AnonHxy opened a new pull request #15002: [broker]Mark sure resetCursorInProgress update even if throw exceptions

AnonHxy opened a new pull request #15002:
URL: https://github.com/apache/pulsar/pull/15002


   ### Motivation
   
   * The `resetCursorInProgress` will not be updated if throws exceptions in the callback. It is dangerous which will cause the following reset cursor requests  always throw `reset already in progress` exceptions.
   
   ### Modifications
   
   Catch any `Throwable`  and update `resetCursorInProgress` anyway
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   
   ### Documentation
     
   - [x] `no-need-doc` 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15002: [broker]Mark sure resetCursorInProgress update even if throw exceptions

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #15002:
URL: https://github.com/apache/pulsar/pull/15002#issuecomment-1086592717


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] AnonHxy commented on pull request #15002: [broker]Mark sure resetCursorInProgress update even if throw exceptions

Posted by GitBox <gi...@apache.org>.
AnonHxy commented on pull request #15002:
URL: https://github.com/apache/pulsar/pull/15002#issuecomment-1086557368


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org