You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Arnaud HERITIER <ah...@gmail.com> on 2008/03/05 17:30:48 UTC

Share surefire plugin settings for all plugins

Hi guys,

  To fix an issue (MECLIPSE-395) to build the eclipse plugin with a fully
customized environment, I had to add in surefire these settings :
          <systemProperties>
            <property>
              <name>maven.home</name>
              <value>${maven.home}</value>
            </property>
            <property>
              <name>org.apache.maven.user-settings</name>
              <value>${org.apache.maven.user-settings}</value>
            </property>
            <property>
              <name>org.apache.maven.global-settings</name>
              <value>${org.apache.maven.global-settings}</value>
            </property>
          </systemProperties>

  I reproduced this issue in others plugins and librairies like the
maven-plugin-testing-tools.

  Couldn't we add these settings in a parent pom ? Which one ? The
maven-plugins parent seems a good location ?
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: Share surefire plugin settings for all plugins

Posted by Arnaud HERITIER <ah...@gmail.com>.
On Wed, Mar 5, 2008 at 9:13 PM, Brett Porter <br...@apache.org> wrote:

> I don't quite understand what you mean. You're saying that if the
> environment you run your tests in uses those variables, and we run
> integration tests that fork Maven, they aren't passed on by default?


yes, exactly.

>
>
> It's a bit ugly - it'd be nicer if the test framework took care of
> that, but I can see what you mean and it might make sense to add them
> in to the parent.


I'll have a look at the maven-plugin-testing-tools to see if we can fix it
in the framework instead of the parent pom but I'm not sure that it is
possible.

Arnaud

>
>
> - Brett
>
> On 06/03/2008, at 3:30 AM, Arnaud HERITIER wrote:
>
> > Hi guys,
> >
> > To fix an issue (MECLIPSE-395) to build the eclipse plugin with a
> > fully
> > customized environment, I had to add in surefire these settings :
> >         <systemProperties>
> >           <property>
> >             <name>maven.home</name>
> >             <value>${maven.home}</value>
> >           </property>
> >           <property>
> >             <name>org.apache.maven.user-settings</name>
> >             <value>${org.apache.maven.user-settings}</value>
> >           </property>
> >           <property>
> >             <name>org.apache.maven.global-settings</name>
> >             <value>${org.apache.maven.global-settings}</value>
> >           </property>
> >         </systemProperties>
> >
> > I reproduced this issue in others plugins and librairies like the
> > maven-plugin-testing-tools.
> >
> > Couldn't we add these settings in a parent pom ? Which one ? The
> > maven-plugins parent seems a good location ?
> > ..........................................................
> > Arnaud HERITIER
> > ..........................................................
> > OCTO Technology - aheritier AT octo DOT com
> > www.octo.com | blog.octo.com
> > ..........................................................
> > ASF - aheritier AT apache DOT org
> > www.apache.org | maven.apache.org
> > ...........................................................
>
> --
> Brett Porter
> brett@apache.org
> http://blogs.exist.com/bporter/
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: Share surefire plugin settings for all plugins

Posted by Brett Porter <br...@apache.org>.
I don't quite understand what you mean. You're saying that if the  
environment you run your tests in uses those variables, and we run  
integration tests that fork Maven, they aren't passed on by default?

It's a bit ugly - it'd be nicer if the test framework took care of  
that, but I can see what you mean and it might make sense to add them  
in to the parent.

- Brett

On 06/03/2008, at 3:30 AM, Arnaud HERITIER wrote:

> Hi guys,
>
> To fix an issue (MECLIPSE-395) to build the eclipse plugin with a  
> fully
> customized environment, I had to add in surefire these settings :
>         <systemProperties>
>           <property>
>             <name>maven.home</name>
>             <value>${maven.home}</value>
>           </property>
>           <property>
>             <name>org.apache.maven.user-settings</name>
>             <value>${org.apache.maven.user-settings}</value>
>           </property>
>           <property>
>             <name>org.apache.maven.global-settings</name>
>             <value>${org.apache.maven.global-settings}</value>
>           </property>
>         </systemProperties>
>
> I reproduced this issue in others plugins and librairies like the
> maven-plugin-testing-tools.
>
> Couldn't we add these settings in a parent pom ? Which one ? The
> maven-plugins parent seems a good location ?
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Share surefire plugin settings for all plugins

Posted by Arnaud HERITIER <ah...@gmail.com>.
I just noticed that my fix doesn't work if those properties aren't defined
(see my comment o*n MECLIPSE-395*).
I don't see how to fix this problem. It's no something that is annoying a
lot of people (that's why I'm the first one t notice it) but if someone can
help me to fix it or to find a workaround it will help me a lot to
participate to maven during my daily job.

cheers

arnaud

On Thu, Mar 6, 2008 at 10:56 AM, Arnaud HERITIER <ah...@gmail.com>
wrote:

> Yes, I suppose that we are few to use those properties (I never used them
> before yesterday) but I agree it should be transparent for plugins
> developments and integration tests. I'll try to find a fix in
> maven-plugin-testing-tools.
>
> Arnaud
>
>
> On Wed, Mar 5, 2008 at 9:34 PM, Jason van Zyl <ja...@maven.org> wrote:
>
> > I doubt we need these for many of the plugins, and the invoker or
> > SHITTY plugin should deal with. I'd rather not see this foisted on
> > everyone.
> >
> > On 5-Mar-08, at 8:30 AM, Arnaud HERITIER wrote:
> >
> > > Hi guys,
> > >
> > >  To fix an issue (MECLIPSE-395) to build the eclipse plugin with a
> > > fully
> > > customized environment, I had to add in surefire these settings :
> > >          <systemProperties>
> > >            <property>
> > >              <name>maven.home</name>
> > >              <value>${maven.home}</value>
> > >            </property>
> > >            <property>
> > >              <name>org.apache.maven.user-settings</name>
> > >              <value>${org.apache.maven.user-settings}</value>
> > >            </property>
> > >            <property>
> > >              <name>org.apache.maven.global-settings</name>
> > >              <value>${org.apache.maven.global-settings}</value>
> > >            </property>
> > >          </systemProperties>
> > >
> > >  I reproduced this issue in others plugins and librairies like the
> > > maven-plugin-testing-tools.
> > >
> > >  Couldn't we add these settings in a parent pom ? Which one ? The
> > > maven-plugins parent seems a good location ?
> > > ..........................................................
> > > Arnaud HERITIER
> > > ..........................................................
> > > OCTO Technology - aheritier AT octo DOT com
> > > www.octo.com | blog.octo.com
> > > ..........................................................
> > > ASF - aheritier AT apache DOT org
> > > www.apache.org | maven.apache.org
> > > ...........................................................
> >
> > Thanks,
> >
> > Jason
> >
> > ----------------------------------------------------------
> > Jason van Zyl
> > Founder,  Apache Maven
> > jason at sonatype dot com
> > ----------------------------------------------------------
> >
> > Simplex sigillum veri. (Simplicity is the seal of truth.)
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
> --
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................
>



-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: Share surefire plugin settings for all plugins

Posted by Arnaud HERITIER <ah...@gmail.com>.
Yes, I suppose that we are few to use those properties (I never used them
before yesterday) but I agree it should be transparent for plugins
developments and integration tests. I'll try to find a fix in
maven-plugin-testing-tools.

Arnaud

On Wed, Mar 5, 2008 at 9:34 PM, Jason van Zyl <ja...@maven.org> wrote:

> I doubt we need these for many of the plugins, and the invoker or
> SHITTY plugin should deal with. I'd rather not see this foisted on
> everyone.
>
> On 5-Mar-08, at 8:30 AM, Arnaud HERITIER wrote:
>
> > Hi guys,
> >
> >  To fix an issue (MECLIPSE-395) to build the eclipse plugin with a
> > fully
> > customized environment, I had to add in surefire these settings :
> >          <systemProperties>
> >            <property>
> >              <name>maven.home</name>
> >              <value>${maven.home}</value>
> >            </property>
> >            <property>
> >              <name>org.apache.maven.user-settings</name>
> >              <value>${org.apache.maven.user-settings}</value>
> >            </property>
> >            <property>
> >              <name>org.apache.maven.global-settings</name>
> >              <value>${org.apache.maven.global-settings}</value>
> >            </property>
> >          </systemProperties>
> >
> >  I reproduced this issue in others plugins and librairies like the
> > maven-plugin-testing-tools.
> >
> >  Couldn't we add these settings in a parent pom ? Which one ? The
> > maven-plugins parent seems a good location ?
> > ..........................................................
> > Arnaud HERITIER
> > ..........................................................
> > OCTO Technology - aheritier AT octo DOT com
> > www.octo.com | blog.octo.com
> > ..........................................................
> > ASF - aheritier AT apache DOT org
> > www.apache.org | maven.apache.org
> > ...........................................................
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> jason at sonatype dot com
> ----------------------------------------------------------
>
> Simplex sigillum veri. (Simplicity is the seal of truth.)
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>


-- 
..........................................................
Arnaud HERITIER
..........................................................
OCTO Technology - aheritier AT octo DOT com
www.octo.com | blog.octo.com
..........................................................
ASF - aheritier AT apache DOT org
www.apache.org | maven.apache.org
...........................................................

Re: Share surefire plugin settings for all plugins

Posted by Jason van Zyl <ja...@maven.org>.
I doubt we need these for many of the plugins, and the invoker or  
SHITTY plugin should deal with. I'd rather not see this foisted on  
everyone.

On 5-Mar-08, at 8:30 AM, Arnaud HERITIER wrote:

> Hi guys,
>
>  To fix an issue (MECLIPSE-395) to build the eclipse plugin with a  
> fully
> customized environment, I had to add in surefire these settings :
>          <systemProperties>
>            <property>
>              <name>maven.home</name>
>              <value>${maven.home}</value>
>            </property>
>            <property>
>              <name>org.apache.maven.user-settings</name>
>              <value>${org.apache.maven.user-settings}</value>
>            </property>
>            <property>
>              <name>org.apache.maven.global-settings</name>
>              <value>${org.apache.maven.global-settings}</value>
>            </property>
>          </systemProperties>
>
>  I reproduced this issue in others plugins and librairies like the
> maven-plugin-testing-tools.
>
>  Couldn't we add these settings in a parent pom ? Which one ? The
> maven-plugins parent seems a good location ?
> ..........................................................
> Arnaud HERITIER
> ..........................................................
> OCTO Technology - aheritier AT octo DOT com
> www.octo.com | blog.octo.com
> ..........................................................
> ASF - aheritier AT apache DOT org
> www.apache.org | maven.apache.org
> ...........................................................

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
jason at sonatype dot com
----------------------------------------------------------

Simplex sigillum veri. (Simplicity is the seal of truth.)




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org