You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "akesling (via GitHub)" <gi...@apache.org> on 2024/12/13 18:24:42 UTC
[PR] MINOR: Schema.fbs typo -- s/maybe/may be/ [arrow]
akesling opened a new pull request, #45023:
URL: https://github.com/apache/arrow/pull/45023
### Rationale for this change
To improve a comment.
### What changes are included in this PR?
Correction of a mispelling in a comment: s/maybe/may be/.
### Are these changes tested?
N/A
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Schema.fbs typo -- s/maybe/may be/ [arrow]
Posted by "zanmato1984 (via GitHub)" <gi...@apache.org>.
zanmato1984 commented on PR #45023:
URL: https://github.com/apache/arrow/pull/45023#issuecomment-2544737825
Hi @akesling , I see you have 5 PRs (#45022 , this one, #45024 , #45025 , #45026 ) fixing single typo in `Schema.fbs`. All of them are good, and thank you for that. But could you combine them into a single PR to keep our commit history cleaner? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Format] Schema.fbs typo -- s/maybe/may be/ [arrow]
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #45023:
URL: https://github.com/apache/arrow/pull/45023#issuecomment-2583373219
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 21feb1673f2dbac61efe35193e321610ac35a0a3.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/35445181672) has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: [Format] Schema.fbs typo -- s/maybe/may be/ [arrow]
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #45023:
URL: https://github.com/apache/arrow/pull/45023
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: Schema.fbs typo -- s/maybe/may be/ [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #45023:
URL: https://github.com/apache/arrow/pull/45023#issuecomment-2545055535
I agree with @zanmato1984 , those PRs could be combined on a single PR fixing various typos.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org