You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jaikiran Pai <ja...@apache.org> on 2018/12/22 03:15:03 UTC
Commit notifications from gitbox [was [ant] branch master updated
(706d818 -> 722ccb7)]
Adding users@infra.apache.org. Comments inline.
On 21/12/18 1:01 AM, bodewig@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> bodewig pushed a change to branch master
> in repository https://gitbox.apache.org/repos/asf/ant.git.
>
>
> from 706d818 moved to gitbox
> add 82a603c Use valid markup
> new 722ccb7 Merge pull request #82 from twogee/invalid-html
>
> The 1 revisions listed above as "new" are entirely new to this
> repository and will be described in separate emails. The revisions
> listed as "add" were already present in the repository and have only
> been added to this reference.
This looks a bit odd. The "Use valid markup" is a new commit and wasn't
there in the upstream repository previously, so not sure why it's being
considered as already present.
Furthermore, the other mail notification which contained the details
about the "new" just listed the files that changed and the line count of
changes. Previously, when we were on git.wip-us repo, these
notifications used to inline the diff within one or more emails and that
format was very convenient to do reviews. Would it be possible to have a
similar format (at least for Ant project(s)) for these notifications?
-Jaikiran
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Commit notifications from gitbox [was [ant] branch master updated (706d818 -> 722ccb7)]
Posted by Stefan Bodewig <bo...@apache.org>.
On 2018-12-22, Jaikiran Pai wrote:
> Adding users@infra.apache.org. Comments inline.
> On 21/12/18 1:01 AM, bodewig@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git repository.
>> bodewig pushed a change to branch master
>> in repository https://gitbox.apache.org/repos/asf/ant.git.
>> from 706d818 moved to gitbox
>> add 82a603c Use valid markup
>> new 722ccb7 Merge pull request #82 from twogee/invalid-html
>> The 1 revisions listed above as "new" are entirely new to this
>> repository and will be described in separate emails. The revisions
>> listed as "add" were already present in the repository and have only
>> been added to this reference.
> This looks a bit odd. The "Use valid markup" is a new commit and wasn't
> there in the upstream repository previously, so not sure why it's being
> considered as already present.
For additional context, this commit was the result of me merging a
github PR via the github UI.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org