You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/06/28 13:50:25 UTC

[GitHub] [beam] bullet03 opened a new pull request, #22076: [Website] add refresh to page-nav.js

bullet03 opened a new pull request, #22076:
URL: https://github.com/apache/beam/pull/22076

   - add refresh method to page-nav.js
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1168753894

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem commented on pull request #22076: [Website] Reverting deletion of refreshScrollSpy in PR 21731

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1177887064

   nice thanks! lgtm


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] alevtinaboiko commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
alevtinaboiko commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1170085718

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1168753893

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] bullet03 commented on pull request #22076: [Website] Reverting deletion of refreshScrollSpy in PR 21731

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1171493228

   before:
   ![before](https://user-images.githubusercontent.com/61748758/176740545-d10c5ca8-9df6-4c88-9119-6e40b4d93579.gif)
   
   after:
   ![after](https://user-images.githubusercontent.com/61748758/176740605-f9aac25c-cb29-4dbd-a53f-2945c2140122.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1168753900

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1168753899

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] asf-ci commented on pull request #22076: [Website] add refresh to page-nav.js

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1168753904

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] AKosolapov commented on pull request #22076: [Website] Reverting deletion of refreshScrollSpy in PR 21731

Posted by GitBox <gi...@apache.org>.
AKosolapov commented on PR #22076:
URL: https://github.com/apache/beam/pull/22076#issuecomment-1177031530

   @pabloem would you kindly help us merge this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [beam] pabloem merged pull request #22076: [Website] Reverting deletion of refreshScrollSpy in PR 21731

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #22076:
URL: https://github.com/apache/beam/pull/22076


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org