You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/13 08:43:58 UTC
[GitHub] [spark] gengliangwang opened a new pull request, #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
gengliangwang opened a new pull request, #39048:
URL: https://github.com/apache/spark/pull/39048
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Add Protobuf serializer for TaskDataWrapper
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Support fast and compact serialization/deserialization for TaskDataWrapper over RocksDB.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
New UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049395696
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
You can take a look at `LiveEntity` on which fields it helps with - this was based on what we saw inhouse.
In case of history server, the number of hosts in a cluster is fairly limited (depends on size of cluster) - but the number of applications + tasks being very large.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049395696
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
You can take a look at `LiveEntity` on which fields it helps with - this was based on what we saw inhouse.
In case of history server, the number of hosts in a cluster is fairly limited (depends on size of cluster) - but the number of applications + tasks being very large.
Applies to others as well (executor id, locality, status, description, etc) - unless the protobuf deserializer is already caching ofcourse !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1050331603
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
@mridulm Thanks. I have updated the code according to https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/status/LiveEntity.scala#L208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on PR #39048:
URL: https://github.com/apache/spark/pull/39048#issuecomment-1354304111
@mridulm @cloud-fan Thanks for the review.
Merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049372734
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
That fix was added based on what was observed in production history server - where the gc impact and the number of duplicate objects was extremely high.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049385403
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
Could you provide more details? Do you mean using `weakIntern` for all the string fields? Will it help the GC if we use `weakIntern(binary.getHost)`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1048143459
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
Discuss: I am yet to look through all the codepaths, but I am wondering if use of `weakIntern` in `LiveEntity` is relevant to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049372734
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
That fix was added based on what was observed in production history server - where the gc impact and the number of duplication objects was extremely high.
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
That fix was added based on what was observed in production history server - where the gc impact and the number of duplicateobjects was extremely high.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] mridulm commented on pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
mridulm commented on PR #39048:
URL: https://github.com/apache/spark/pull/39048#issuecomment-1354303023
Thanks for working on this @gengliangwang !
Do you mind merging it ? I am afk from my personal desktop ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang closed pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang closed pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
URL: https://github.com/apache/spark/pull/39048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] gengliangwang commented on a diff in pull request #39048: [SPARK-41424][UI] Protobuf serializer for TaskDataWrapper
Posted by GitBox <gi...@apache.org>.
gengliangwang commented on code in PR #39048:
URL: https://github.com/apache/spark/pull/39048#discussion_r1049145069
##########
core/src/main/scala/org/apache/spark/status/protobuf/TaskDataWrapperSerializer.scala:
##########
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.status.protobuf
+
+import scala.collection.mutable.ArrayBuffer
+
+import org.apache.spark.status.TaskDataWrapper
+import org.apache.spark.status.api.v1.AccumulableInfo
+import org.apache.spark.status.protobuf.Utils.getOptional
+
+object TaskDataWrapperSerializer {
+ def serialize(input: TaskDataWrapper): Array[Byte] = {
+ val builder = StoreTypes.TaskDataWrapper.newBuilder()
+ .setTaskId(input.taskId)
+ .setIndex(input.index)
+ .setAttempt(input.attempt)
+ .setPartitionId(input.partitionId)
+ .setLaunchTime(input.launchTime)
+ .setResultFetchStart(input.resultFetchStart)
+ .setDuration(input.duration)
+ .setExecutorId(input.executorId)
+ .setHost(input.host)
+ .setStatus(input.status)
+ .setTaskLocality(input.taskLocality)
+ .setSpeculative(input.speculative)
+ .setHasMetrics(input.hasMetrics)
+ .setExecutorDeserializeTime(input.executorDeserializeTime)
+ .setExecutorDeserializeCpuTime(input.executorDeserializeCpuTime)
+ .setExecutorRunTime(input.executorRunTime)
+ .setExecutorCpuTime(input.executorCpuTime)
+ .setResultSize(input.resultSize)
+ .setJvmGcTime(input.jvmGcTime)
+ .setResultSerializationTime(input.resultSerializationTime)
+ .setMemoryBytesSpilled(input.memoryBytesSpilled)
+ .setDiskBytesSpilled(input.diskBytesSpilled)
+ .setPeakExecutionMemory(input.peakExecutionMemory)
+ .setInputBytesRead(input.inputBytesRead)
+ .setInputRecordsRead(input.inputRecordsRead)
+ .setOutputBytesWritten(input.outputBytesWritten)
+ .setOutputRecordsWritten(input.outputRecordsWritten)
+ .setShuffleRemoteBlocksFetched(input.shuffleRemoteBlocksFetched)
+ .setShuffleLocalBlocksFetched(input.shuffleLocalBlocksFetched)
+ .setShuffleFetchWaitTime(input.shuffleFetchWaitTime)
+ .setShuffleRemoteBytesRead(input.shuffleRemoteBytesRead)
+ .setShuffleRemoteBytesReadToDisk(input.shuffleRemoteBytesReadToDisk)
+ .setShuffleLocalBytesRead(input.shuffleLocalBytesRead)
+ .setShuffleRecordsRead(input.shuffleRecordsRead)
+ .setShuffleBytesWritten(input.shuffleBytesWritten)
+ .setShuffleWriteTime(input.shuffleWriteTime)
+ .setShuffleRecordsWritten(input.shuffleRecordsWritten)
+ .setStageId(input.stageId)
+ .setStageAttemptId(input.stageAttemptId)
+ input.errorMessage.foreach(builder.setErrorMessage)
+ input.accumulatorUpdates.foreach { update =>
+ builder.addAccumulatorUpdates(serializeAccumulableInfo(update))
+ }
+ builder.build().toByteArray
+ }
+
+ def deserialize(bytes: Array[Byte]): TaskDataWrapper = {
+ val binary = StoreTypes.TaskDataWrapper.parseFrom(bytes)
+ val accumulatorUpdates = new ArrayBuffer[AccumulableInfo]()
+ binary.getAccumulatorUpdatesList.forEach { update =>
+ accumulatorUpdates.append(new AccumulableInfo(
+ id = update.getId,
+ name = update.getName,
+ update = getOptional(update.hasUpdate, update.getUpdate),
+ value = update.getValue))
+ }
+ new TaskDataWrapper(
+ taskId = binary.getTaskId,
+ index = binary.getIndex,
+ attempt = binary.getAttempt,
+ partitionId = binary.getPartitionId,
+ launchTime = binary.getLaunchTime,
+ resultFetchStart = binary.getResultFetchStart,
+ duration = binary.getDuration,
+ executorId = binary.getExecutorId,
+ host = binary.getHost,
+ status = binary.getStatus,
+ taskLocality = binary.getTaskLocality,
+ speculative = binary.getSpeculative,
+ accumulatorUpdates = accumulatorUpdates.toSeq,
+ errorMessage = getOptional(binary.hasErrorMessage, binary.getErrorMessage),
+ hasMetrics = binary.getHasMetrics,
+ executorDeserializeTime = binary.getExecutorDeserializeTime,
+ executorDeserializeCpuTime = binary.getExecutorDeserializeCpuTime,
+ executorRunTime = binary.getExecutorRunTime,
+ executorCpuTime = binary.getExecutorCpuTime,
+ resultSize = binary.getResultSize,
+ jvmGcTime = binary.getJvmGcTime,
+ resultSerializationTime = binary.getResultSerializationTime,
+ memoryBytesSpilled = binary.getMemoryBytesSpilled,
+ diskBytesSpilled = binary.getDiskBytesSpilled,
+ peakExecutionMemory = binary.getPeakExecutionMemory,
+ inputBytesRead = binary.getInputBytesRead,
+ inputRecordsRead = binary.getInputRecordsRead,
+ outputBytesWritten = binary.getOutputBytesWritten,
+ outputRecordsWritten = binary.getOutputRecordsWritten,
+ shuffleRemoteBlocksFetched = binary.getShuffleRemoteBlocksFetched,
+ shuffleLocalBlocksFetched = binary.getShuffleLocalBlocksFetched,
+ shuffleFetchWaitTime = binary.getShuffleFetchWaitTime,
+ shuffleRemoteBytesRead = binary.getShuffleRemoteBytesRead,
+ shuffleRemoteBytesReadToDisk = binary.getShuffleRemoteBytesReadToDisk,
+ shuffleLocalBytesRead = binary.getShuffleLocalBytesRead,
+ shuffleRecordsRead = binary.getShuffleRecordsRead,
+ shuffleBytesWritten = binary.getShuffleBytesWritten,
+ shuffleWriteTime = binary.getShuffleWriteTime,
+ shuffleRecordsWritten = binary.getShuffleRecordsWritten,
+ stageId = binary.getStageId.toInt,
+ stageAttemptId = binary.getStageAttemptId
Review Comment:
I think that's a bit complicated. I prefer keeping it simple for now. The project helps reduce memory usage already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org