You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Steve Loughran (JIRA)" <ji...@apache.org> on 2017/03/01 16:51:45 UTC
[jira] [Commented] (HADOOP-14135) Remove URI parameter in
AWSCredentialProvider constructors
[ https://issues.apache.org/jira/browse/HADOOP-14135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15890535#comment-15890535 ]
Steve Loughran commented on HADOOP-14135:
-----------------------------------------
I'll need to look at this carefully. we pass down to URIs, one stripped of auth details (For error messages/logging) and one which can be used to extract credentials from. We need to avoid ever logging the URI with the secrets
> Remove URI parameter in AWSCredentialProvider constructors
> ----------------------------------------------------------
>
> Key: HADOOP-14135
> URL: https://issues.apache.org/jira/browse/HADOOP-14135
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Reporter: Mingliang Liu
> Assignee: Mingliang Liu
> Attachments: HADOOP-14135.000.patch
>
>
> This was from comment in [HADOOP-13252].
> It looks like the URI parameter is not needed for our AWSCredentialProvider constructors. This was useful because we relied on URI parameter for retrieving user:pass. Now in binding URIs, we have
> {code}
> 279 S3xLoginHelper.Login creds = getAWSAccessKeys(binding, conf);
> 280 credentials.add(new BasicAWSCredentialsProvider(
> 281 creds.getUser(), creds.getPassword()));
> {code}
> This way, we only need configuration object (if necessary) for all AWSCredentialProvider implementations. The benefit is that, if we create AWSCredentialProvider list for DynamoDB, we don't have to pass down the associated file system URI. This might be useful to S3Guard tools.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org