You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/07 11:31:17 UTC
[GitHub] [incubator-pekko] pjfanning opened a new pull request, #148: replace use of unmaintained setup-scala action
pjfanning opened a new pull request, #148:
URL: https://github.com/apache/incubator-pekko/pull/148
related to https://github.com/apache/incubator-pekko-connectors-kafka/pull/26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098568040
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning merged pull request #148: replace use of unmaintained setup-scala action
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098584129
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
Thanks for clarifying, had a misunderstanding then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098582149
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
```
You can use the following syntax to define read or write access for all of the available scopes:
permissions: read-all|write-all
You can use the following syntax to disable permissions for all of the available scopes:
permissions: {}
```
Having no permissions to read secrets is safer than having the ability to read secrets.
I work on other OSS projects and `permissions: {}` was what people were sending those projects in PRs - as being the best setting to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098586226
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
To be frank, the Github docs are not well written - leaving plenty of ambiguity.
I'm not sure why not setting permissions at all in the yml does not default to having the lowest available permissions.
A few months ago, there were people popping PRs on dozens of repos to set `permissions: {}` but honestly, they could have been wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098566736
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
I don't think read-all is needed. `{}` disables the jobs access to repository secrets - and this should be the go-to setting unless a job needs to read secrets
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #148: replace use of unmaintained setup-scala action
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #148:
URL: https://github.com/apache/incubator-pekko/pull/148#discussion_r1098577257
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
Are you sure this is what you intend? `read-all` is more strict than `{}`, not less.
##########
.github/workflows/format.yml:
##########
@@ -1,6 +1,6 @@
name: Scalafmt
-permissions: read-all
+permissions: {}
Review Comment:
Are you sure this is what you intend? `read-all` is more strict than `{}`, not less.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org