You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by radarwave <gi...@git.apache.org> on 2016/12/21 03:00:50 UTC

[GitHub] incubator-hawq pull request #1059: HAWQ-1229. Remove verbose option in hawq ...

GitHub user radarwave opened a pull request:

    https://github.com/apache/incubator-hawq/pull/1059

    HAWQ-1229. Remove verbose option in hawq config

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/radarwave/incubator-hawq config_verbose

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-hawq/pull/1059.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1059
    
----
commit 5ac1a23db4eb2b2ebc026c94f35cb77a09dd8393
Author: rlei <rl...@pivotal.io>
Date:   2016-12-21T02:59:13Z

    HAWQ-1229. Remove verbose option in hawq config

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1059: HAWQ-1229. Remove verbose option in hawq ...

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1059#discussion_r93384000
  
    --- Diff: tools/bin/hawqpylib/HAWQ_HELP.py ---
    @@ -159,10 +159,10 @@
     
     The "options" are:
        -c --change         Changes a configuration parameter setting.
    --- End diff --
    
    How. Then +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1059: HAWQ-1229. Remove verbose option in hawq config

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1059
  
    '-v' seem to have another usage in "hawq config"?
    
    [-v hawq_property_value | --value=hawq_property_value


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1059: HAWQ-1229. Remove verbose option in hawq config

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1059
  
    I mean why not replace this time.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1059: HAWQ-1229. Remove verbose option in hawq config

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1059
  
    Good point, I will update it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1059: HAWQ-1229. Remove verbose option in hawq ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-hawq/pull/1059


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq pull request #1059: HAWQ-1229. Remove verbose option in hawq ...

Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on a diff in the pull request:

    https://github.com/apache/incubator-hawq/pull/1059#discussion_r93370544
  
    --- Diff: tools/bin/hawqpylib/HAWQ_HELP.py ---
    @@ -159,10 +159,10 @@
     
     The "options" are:
        -c --change         Changes a configuration parameter setting.
    --- End diff --
    
    Actually I think "--change" could better be "--parameter"? ". How do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1059: HAWQ-1229. Remove verbose option in hawq config

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1059
  
    @paul-guo- Please review. Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-hawq issue #1059: HAWQ-1229. Remove verbose option in hawq config

Posted by radarwave <gi...@git.apache.org>.
Github user radarwave commented on the issue:

    https://github.com/apache/incubator-hawq/pull/1059
  
    Yeah, '-v' is used to set the GUC value. '--verbose' is a legacy option, now it's already been removed. This time only remove the wrong help message.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---