You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "Mridul Pathak (Jira)" <ji...@apache.org> on 2026/09/29 14:35:00 UTC
[jira] [Closed] (OFBIZ-13621) Six regressions in the minilang-to-Groovy conversion of ProductServicesScript.groovy, including a guaranteed crash and a permission-scope gap
[ https://issues.apache.org/jira/browse/OFBIZ-13621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mridul Pathak closed OFBIZ-13621.
---------------------------------
Fix Version/s: Upcoming Branch
24.09.08
Resolution: Fixed
> Six regressions in the minilang-to-Groovy conversion of ProductServicesScript.groovy, including a guaranteed crash and a permission-scope gap
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-13621
> URL: https://issues.apache.org/jira/browse/OFBIZ-13621
> Project: OFBiz
> Issue Type: Bug
> Components: product/catalog
> Affects Versions: Upcoming Branch, 24.09.07
> Reporter: Mridul Pathak
> Assignee: Mridul Pathak
> Priority: Critical
> Fix For: Upcoming Branch, 24.09.08
>
>
> *1. {{deleteProductGroupOrder()}} always throws — CRITICAL*
> {{productGroupOrder.removeRelated('OrderItemGroupOrder')}} — no such relation exists on {{ProductGroupOrder}}'s entity model, so this throws every time. The parent is also removed before its children, which would violate the FK even if the relation name were fixed. Needs reordering plus a correct child-removal query.
> *2. {{checkProductRelatedPermission()}} drops a date filter — security-relevant*
> {{.filterByDate('roleFromDate', 'roleThruDate')}} replaces rather than adds to the default filter pair, so the product's own category-membership window is never checked — only the party's role-assignment window is. A limited-admin can retain edit/delete rights on a product whose category membership has expired. Fix: pass both pairs in one call.
> *3-4. Added {{.cache()}} not in the original mini-lang*
> {{forceIndexProductKeywords()}} and {{deleteProductKeywords()}}'s {{Product}} lookups now cache; the force-reindex method in particular can read stale data.
> *5. Groovy truthiness on {{cancelQuantity}}*
> {{orderItem.cancelQuantity ?: orderItem.quantity}} wrongly falls back when {{cancelQuantity}} is legitimately 0.
> *6. Wrong string in {{updateProductQuickAdminName()}}*
> Passes {{'updateQuickAdminName'}} instead of {{'updateProductQuickAdminName'}} — cosmetic, wrong text in a permission-denied message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)