You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/08/18 11:59:59 UTC

[GitHub] [flink] hequn8128 opened a new pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

hequn8128 opened a new pull request #13192:
URL: https://github.com/apache/flink/pull/13192


   ## What is the purpose of the change
   
   This pull request adds Python api tutorial under Python GettingStart. The tutorial that tells users how to set up a Python project, how to write jobs and how to run jobs locally.
   
   
   ## Brief change log
   
     - Move Try Flink tutorial under Python GettingStart.
     - Add pointers in the original document page.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13192:
URL: https://github.com/apache/flink/pull/13192#discussion_r473290661



##########
File path: docs/try-flink/python_table_api.md
##########
@@ -23,161 +23,9 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-This walkthrough will quickly get you started building a pure Python Flink project.

Review comment:
       that's fine then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on a change in pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on a change in pull request #13192:
URL: https://github.com/apache/flink/pull/13192#discussion_r472587408



##########
File path: docs/try-flink/python_table_api.md
##########
@@ -23,161 +23,9 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-This walkthrough will quickly get you started building a pure Python Flink project.

Review comment:
       Hi, the Python DataStream tutorial will also be added to this page(FLINK-18984). I was thinking about keeping this page in `Try Flink` and add both Python Table API tutorial link and Python DataStream API tutorial link in it. 
   
   What do you think?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13192:
URL: https://github.com/apache/flink/pull/13192#issuecomment-675441637


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6886d8199e64869f6a3274739dad8fb0382941ea UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13192:
URL: https://github.com/apache/flink/pull/13192#discussion_r472295558



##########
File path: docs/try-flink/python_table_api.md
##########
@@ -23,161 +23,9 @@ specific language governing permissions and limitations
 under the License.

Review comment:
       If you are moving the content, please just delete this page and setup a redirect. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] sjwiesman commented on a change in pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
sjwiesman commented on a change in pull request #13192:
URL: https://github.com/apache/flink/pull/13192#discussion_r472296000



##########
File path: docs/try-flink/python_table_api.md
##########
@@ -23,161 +23,9 @@ specific language governing permissions and limitations
 under the License.
 -->
 
-This walkthrough will quickly get you started building a pure Python Flink project.

Review comment:
       If you're moving the content, please just delete this page and setup a redirect. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 commented on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
hequn8128 commented on pull request #13192:
URL: https://github.com/apache/flink/pull/13192#issuecomment-676849042


   @sjwiesman Thanks a lot for the review. Merging...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] hequn8128 merged pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
hequn8128 merged pull request #13192:
URL: https://github.com/apache/flink/pull/13192


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13192:
URL: https://github.com/apache/flink/pull/13192#issuecomment-675441637


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5681",
       "triggerID" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6886d8199e64869f6a3274739dad8fb0382941ea Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5681) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13192:
URL: https://github.com/apache/flink/pull/13192#issuecomment-675441637


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5681",
       "triggerID" : "6886d8199e64869f6a3274739dad8fb0382941ea",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6886d8199e64869f6a3274739dad8fb0382941ea Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=5681) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #13192: [FLINK-18912][python][docs] Add Python api tutorial under Python GettingStart

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13192:
URL: https://github.com/apache/flink/pull/13192#issuecomment-675436567


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 6886d8199e64869f6a3274739dad8fb0382941ea (Tue Aug 18 12:02:11 UTC 2020)
   
    ✅no warnings
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org