You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by James Peach <jp...@apache.org> on 2017/10/20 16:27:11 UTC
Review Request 63183: Stopped awaiting the connected event in ports
isolator tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/
-----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
Repository: mesos
Description
-------
Rather than explicitly waiting for the `connected` scheduler event,
consistently apply the testing pattern from the default executor
tests. We expect that the `connected` event happens, but we only
need to synchronize the test on the `subscribed` event.
Diffs
-----
src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
Diff: https://reviews.apache.org/r/63183/diff/1/
Testing
-------
sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
(Fedora 26)
Thanks,
James Peach
Re: Review Request 63183: Stopped awaiting the connected event in
ports isolator tests.
Posted by Gaston Kleiman <ga...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/#review188848
-----------------------------------------------------------
Ship it!
Ship It!
- Gaston Kleiman
On Oct. 20, 2017, 9:27 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63183/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 9:27 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rather than explicitly waiting for the `connected` scheduler event,
> consistently apply the testing pattern from the default executor
> tests. We expect that the `connected` event happens, but we only
> need to synchronize the test on the `subscribed` event.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
>
>
> Diff: https://reviews.apache.org/r/63183/diff/1/
>
>
> Testing
> -------
>
> sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
>
> (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63183: Stopped awaiting the connected event in
ports isolator tests.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/#review188871
-----------------------------------------------------------
Patch looks great!
Reviews applied: [63183]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Oct. 20, 2017, 4:27 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63183/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rather than explicitly waiting for the `connected` scheduler event,
> consistently apply the testing pattern from the default executor
> tests. We expect that the `connected` event happens, but we only
> need to synchronize the test on the `subscribed` event.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
>
>
> Diff: https://reviews.apache.org/r/63183/diff/1/
>
>
> Testing
> -------
>
> sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
>
> (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63183: Stopped awaiting the connected event in
ports isolator tests.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/#review189566
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Oct. 30, 2017, 11:42 a.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63183/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 11:42 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Bugs: MESOS-8094
> https://issues.apache.org/jira/browse/MESOS-8094
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rather than explicitly waiting for the `connected` scheduler event,
> consistently apply the testing pattern from the default executor
> tests. We expect that the `connected` event happens, but we only
> need to synchronize the test on the `subscribed` event.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
>
>
> Diff: https://reviews.apache.org/r/63183/diff/1/
>
>
> Testing
> -------
>
> sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
>
> (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>
Re: Review Request 63183: Stopped awaiting the connected event in
ports isolator tests.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/
-----------------------------------------------------------
(Updated Oct. 30, 2017, 11:42 a.m.)
Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
Bugs: MESOS-8094
https://issues.apache.org/jira/browse/MESOS-8094
Repository: mesos
Description
-------
Rather than explicitly waiting for the `connected` scheduler event,
consistently apply the testing pattern from the default executor
tests. We expect that the `connected` event happens, but we only
need to synchronize the test on the `subscribed` event.
Diffs
-----
src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
Diff: https://reviews.apache.org/r/63183/diff/1/
Testing
-------
sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
(Fedora 26)
Thanks,
James Peach
Re: Review Request 63183: Stopped awaiting the connected event in
ports isolator tests.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63183/#review188929
-----------------------------------------------------------
PASS: Mesos patch 63183 was successfully built and tested.
Reviews applied: `['63183']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/63183
- Mesos Reviewbot Windows
On Oct. 20, 2017, 4:27 p.m., James Peach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63183/
> -----------------------------------------------------------
>
> (Updated Oct. 20, 2017, 4:27 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Gaston Kleiman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rather than explicitly waiting for the `connected` scheduler event,
> consistently apply the testing pattern from the default executor
> tests. We expect that the `connected` event happens, but we only
> need to synchronize the test on the `subscribed` event.
>
>
> Diffs
> -----
>
> src/tests/containerizer/ports_isolator_tests.cpp 7a19193d2027d51319c3a69a97bfae1fa819845b
>
>
> Diff: https://reviews.apache.org/r/63183/diff/1/
>
>
> Testing
> -------
>
> sudo ./mesos-tests --gtest_repeat=10 --gtest_break_on_failure --gtest_filter=NetworkPorts*
>
> (Fedora 26)
>
>
> Thanks,
>
> James Peach
>
>