You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@johnzon.apache.org by GitBox <gi...@apache.org> on 2022/02/18 20:30:13 UTC
[GitHub] [johnzon] rotty3000 opened a new pull request #78: JOHNZON-359 Fix lost OSGi metadata
rotty3000 opened a new pull request #78:
URL: https://github.com/apache/johnzon/pull/78
Reverts the packaging change from b221d9db923c142afcddde056abd9301acbf9af1
Signed-off-by: Raymond Augé <ro...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1045205382
Plugin was broken on a modern jvm IIRC and was blocking some testing+feature.
Dont get me wrong, was not an intended change but im also looking to a way to not limit such side effect - even maintaining manually the direct manifest.mf in the fatjar - static deps - sounds not bad right now to me compared to bundle/bnd plugins so really just looking for a long term "not bad compromise" solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau merged pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau merged pull request #78:
URL: https://github.com/apache/johnzon/pull/78
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046049073
Your changes look ok to me, just would need to recheck why it had been broken so maybe wait a few days (at least monday) please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046033213
The checks I performed locally was just:
```
export JAVA_HOME=/usr/lib/jvm/...[8|11|17]
mvn clean verify
```
Why the CI failed? I don't know. I need to check the invocation to see what is different.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046033996
Right, so I don't think the CI failure is related to my changes. the error is:
```
[ERROR] Failed to execute goal on project apache-johnzon: Could not resolve dependencies for project org.apache.johnzon:apache-johnzon:jar:1.2.17-SNAPSHOT: The following artifacts could not be resolved: org.apache.johnzon:johnzon-core:jar:javadoc:1.2.17-SNAPSHOT, org.apache.johnzon:johnzon-mapper:jar:javadoc:1.2.17-SNAPSHOT, org.apache.johnzon:johnzon-jaxrs:jar:javadoc:1.2.17-SNAPSHOT, org.apache.johnzon:johnzon-websocket:jar:javadoc:1.2.17-SNAPSHOT, org.apache.johnzon:johnzon-maven-plugin:jar:javadoc:1.2.17-SNAPSHOT, org.apache.johnzon:johnzon-jsonb:jar:javadoc:1.2.17-SNAPSHOT: Failure to find org.apache.johnzon:johnzon-core:jar:javadoc:1.2.17-SNAPSHOT in https://oss.sonatype.org/content/repositories/snapshots/ was cached in the local repository, resolution will not be reattempted until the update interval of sonatype-snapshots has elapsed or updates are forced -> [Help 1]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046285668
Retested on my side, seems some side effect of the bundle plugins (didnt fully reproduced but was related to the stored state in home so guess it can be a local/perm issue).
Thanks a lot Ray!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1045199381
Not sure how the JVM is involved here.
Next, I think it's not particularly fair to your community to do such a change in a point release.
Finally, doing a fat jar for OSGi could easily be a solution if that's the direction you wish to go.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on a change in pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on a change in pull request #78:
URL: https://github.com/apache/johnzon/pull/78#discussion_r810642788
##########
File path: johnzon-maven-plugin/pom.xml
##########
@@ -119,4 +119,86 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046030733
@rmannibucau I did the work to verify that it builds and runs up to Java 17, I don't see any reason it would not even work beyond that with this change either. All tests passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on a change in pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on a change in pull request #78:
URL: https://github.com/apache/johnzon/pull/78#discussion_r810590335
##########
File path: johnzon-maven-plugin/pom.xml
##########
@@ -119,4 +119,86 @@
</plugin>
</plugins>
</build>
+
+ <profiles>
+ <profile>
+ <id>jdk9+</id>
+ <activation>
+ <jdk>[9,)</jdk>
+ </activation>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
Review comment:
let's keep this PR about OSGi maybe
side note: if we compile the generated classes, I'd be to do it in the test doing the generation with ToolProvider or a plain System.getProperty(java.home) + javac lookup and not a maven plugin to keep it consistent and localized. For record java.version can be tested but releases will be done with java 8 (or 11) so not sure it will help to prevent much in the future at community level.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046056981
hey I solved the limitations with building on Java 18-ea as well.
See https://github.com/rotty3000/johnzon/actions/runs/1869360261
I just have a windows test failure to resolve.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rmannibucau commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rmannibucau commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1045179993
Need to check against recent jvm - guess it is why it got dropped and forgotten to be readded - but shouldnt we do a fat jar in osgi module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [johnzon] rotty3000 commented on pull request #78: JOHNZON-359 Fix lost OSGi metadata
Posted by GitBox <gi...@apache.org>.
rotty3000 commented on pull request #78:
URL: https://github.com/apache/johnzon/pull/78#issuecomment-1046114743
I solved the windows issue in the last commit on this PR. I've removed the github actions commit but this branch [here](https://github.com/rotty3000/johnzon/tree/github.actions) has the same commits and [passes](https://github.com/rotty3000/johnzon/actions/runs/1870066312) on all tested platforms:
- Linux: Java 8, Java 11, Java 17, Java 18-ea
- Windows: Java 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@johnzon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org