You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2019/11/25 19:49:12 UTC

svn commit: r1870421 - /pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Author: tilman
Date: Mon Nov 25 19:49:12 2019
New Revision: 1870421

URL: http://svn.apache.org/viewvc?rev=1870421&view=rev
Log:
PDFBOX-3017: don't return null (which will go NPE) when the type of the element is wrong or could not be created, throw exception instead

Modified:
    pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java

Modified: pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java
URL: http://svn.apache.org/viewvc/pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java?rev=1870421&r1=1870420&r2=1870421&view=diff
==============================================================================
--- pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java (original)
+++ pdfbox/branches/issue4569/examples/src/main/java/org/apache/pdfbox/examples/signature/validation/AddValidationInformation.java Mon Nov 25 19:49:12 2019
@@ -198,8 +198,7 @@ public class AddValidationInformation
             }
             catch (ReflectiveOperationException | SecurityException e)
             {
-                LOG.error("Failed to create new instance of " + clazz.getCanonicalName(), e);
-                return null;
+                throw new IOException("Failed to create new instance of " + clazz.getCanonicalName(), e);
             }
             result.setDirect(false);
             parent.setItem(COSName.getPDFName(name), result);