[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6758: Ova download fix

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6758:
URL: https://github.com/apache/cloudstack/pull/6758#discussion_r982566537


##########
engine/storage/src/main/java/org/apache/cloudstack/storage/image/deployasis/DeployAsIsHelperImpl.java:
##########
@@ -190,7 +194,7 @@ private Long retrieveTemplateGuestOsIdFromGuestOsInfo(long templateId, String gu
             }
             return guestOsId;
         } else {
-            throw new CloudRuntimeException("Did not find a guest OS with type " + guestOsType);
+            throw new CloudRuntimeException(String.format("Did not find a guest OS (%s) with type \"%s\" and minimal hyperviser hardware version %s.", guestOsDescription, guestOsType, minimumHardwareVersion));

Review Comment:
   ```suggestion
               throw new CloudRuntimeException(String.format("Did not find a guest OS (%s) with type \"%s\" and minimal hypervisor hardware version %s.", guestOsDescription, guestOsType, minimumHardwareVersion));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org