You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Robert Munteanu (Created) (JIRA)" <ji...@apache.org> on 2012/03/23 17:11:28 UTC
[jira] [Created] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
----------------------------------------------------------------------------------
Key: SLING-2448
URL: https://issues.apache.org/jira/browse/SLING-2448
Project: Sling
Issue Type: Bug
Components: JCR
Affects Versions: JCR Resource 2.0.10
Reporter: Robert Munteanu
Priority: Minor
Attachments: SLING-2448.txt
org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SLING-2448)
org.apache.sling.jcr.resource should embed
com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245153#comment-13245153 ]
Robert Munteanu edited comment on SLING-2448 at 4/3/12 12:14 PM:
-----------------------------------------------------------------
Here's a patch with removes the guava dependency completely. I've ran mvn clean verify in the bundle directory and all tests pass.
was (Author: rmuntean):
Here's a a patch with removes the guava dependency completely. I've ran mvn clean verify in the bundle directory and all tests pass.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Carsten Ziegeler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler closed SLING-2448.
-----------------------------------
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: JCR Resource 2.1.0
>
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated SLING-2448:
-----------------------------------
Attachment: eclipse-errors.png
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238302#comment-13238302 ]
Robert Munteanu commented on SLING-2448:
----------------------------------------
There are efforts underway to make the Guava bundle OSGi-fied out of the box , see [Guava issue 688|http://code.google.com/p/guava-libraries/issues/detail?id=688] . Since this is a general-purpose library, we might consider not embedding it and making it a dependency.. The total size for the r09 jar is 1.1 MB though, and if size is a concern this is not an attractive option.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245153#comment-13245153 ]
Robert Munteanu commented on SLING-2448:
----------------------------------------
Here's a ap patch with removes the guava dependency completely. I've ran mvn clean verify in the bundle directory and all tests pass.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238504#comment-13238504 ]
Carsten Ziegeler commented on SLING-2448:
-----------------------------------------
I'm wondering if we need the functionality at all as we're just using very little of the whole lib.
Having Guava as a bundle would solve the potential size problem but would add another (large) lib to the list of required bundles
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (SLING-2448)
org.apache.sling.jcr.resource should embed
com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245153#comment-13245153 ]
Robert Munteanu edited comment on SLING-2448 at 4/3/12 12:14 PM:
-----------------------------------------------------------------
Here's a a patch with removes the guava dependency completely. I've ran mvn clean verify in the bundle directory and all tests pass.
was (Author: rmuntean):
Here's a ap patch with removes the guava dependency completely. I've ran mvn clean verify in the bundle directory and all tests pass.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Carsten Ziegeler (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler reassigned SLING-2448:
---------------------------------------
Assignee: Carsten Ziegeler
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Assignee: Carsten Ziegeler
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Carsten Ziegeler (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13245298#comment-13245298 ]
Carsten Ziegeler commented on SLING-2448:
-----------------------------------------
Thanks Robert, lgtm - if noone objects I'll commit this patch in the next days.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236723#comment-13236723 ]
Robert Munteanu commented on SLING-2448:
----------------------------------------
Patch which includes the MapDifference class in the embedded resources.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Justin Edelson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13236841#comment-13236841 ]
Justin Edelson commented on SLING-2448:
---------------------------------------
Can you explain how this manifests itself? The use of Guava's Maps class (in fact the use of Guava at all) is an internal implementation detail of this bundle and is not exposed to consumers. Only the Guava classes which are actually required by the bundle are embedded.
Adding this extra class isn't that big a deal, but it looks like unnecessary bloat.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238189#comment-13238189 ]
Robert Munteanu commented on SLING-2448:
----------------------------------------
In reply to comment #2:
> Can you explain how this manifests itself? The use of Guava's Maps class (in
> fact the use of Guava at all) is an internal implementation detail of this
> bundle and is not exposed to consumers. Only the Guava classes which are
> actually required by the bundle are embedded.
The issue here is how Eclipse handles classes found in attached libraries rather than in compilation using javac or runtime usage. Eclipse analyses the Maps class and notices that one of the methods references the MadDifference interface. It tries to resolve it but fails and therefore generates a compilation error.
I suspect that compiling the bundle using ecj would generate the same error , but I did not check that.
I will attach a screenshot of what I usually get in Eclipse for this error.
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated SLING-2448:
-----------------------------------
Attachment: SLING-2448.txt
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Carsten Ziegeler (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carsten Ziegeler resolved SLING-2448.
-------------------------------------
Resolution: Fixed
Fix Version/s: JCR Resource 2.1.0
Thanks for your patch Robert, I've applied it in revision 1325138
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Assignee: Carsten Ziegeler
> Priority: Minor
> Fix For: JCR Resource 2.1.0
>
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SLING-2448) org.apache.sling.jcr.resource should
embed com.google.common.collect.MapDifference
Posted by "Robert Munteanu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Munteanu updated SLING-2448:
-----------------------------------
Attachment: SLING-2448-remove-guava.txt
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448-remove-guava.txt, SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SLING-2448) org.apache.sling.jcr.resource
should embed com.google.common.collect.MapDifference
Posted by "Felix Meschberger (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SLING-2448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13238291#comment-13238291 ]
Felix Meschberger commented on SLING-2448:
------------------------------------------
I think adding this class to the bundle does not hurt (it does not make the bundle substantially larger).
The bigger problem, I have with the inclusion of the Guava parts themselves, because they make the bundle substantially larger (~25% !).
> org.apache.sling.jcr.resource should embed com.google.common.collect.MapDifference
> ----------------------------------------------------------------------------------
>
> Key: SLING-2448
> URL: https://issues.apache.org/jira/browse/SLING-2448
> Project: Sling
> Issue Type: Bug
> Components: JCR
> Affects Versions: JCR Resource 2.0.10
> Reporter: Robert Munteanu
> Priority: Minor
> Attachments: SLING-2448.txt, eclipse-errors.png
>
>
> org.apache.sling.jcr.resource embeds parts of the guava bundle inconsistently. It embeds the Map class, but not the MapDifference interface, which is directly refered from the Maps class.
> This error is typically flagged in Eclipse with a very cryptic message: 'The project was not built since its build path is incomplete. Cannot find the class file for com.google.common.collect.MapDifference$ValueDifference. Fix the build path then try building this project'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira