[jira] [Commented] (SPARK-35763) Minor refactor of StateStoreCustomMetric

["Apache Spark (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-35763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17363408#comment-17363408 ] 

Apache Spark commented on SPARK-35763:
--------------------------------------

User 'vkorukanti' has created a pull request for this issue:
https://github.com/apache/spark/pull/32914

> Minor refactor of StateStoreCustomMetric
> ----------------------------------------
>
>                 Key: SPARK-35763
>                 URL: https://issues.apache.org/jira/browse/SPARK-35763
>             Project: Spark
>          Issue Type: Improvement
>          Components: Structured Streaming
>    Affects Versions: 3.1.2
>            Reporter: Venki Korukanti
>            Priority: Trivial
>
> Code in {{[SymmetricHashJoinStateManager|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/SymmetricHashJoinStateManager.scala#L321]}} relies on the subclass implementations of [StateStoreCustomMetric|https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/StateStore.scala#L187].
> If a new subclass of {{StateStoreCustomMetric}} is added, it requires code changes to {{SymmetricHashJoinStateManager}} and we may miss the update if there is no existing test coverage.
> To fix this, add new method to trait {{withNewDesc(desc : String)}} to {{StateStoreCustomMetric}} and use it in {{SymmetricHashJoinStateManager}}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org