[GitHub] [spark] HyukjinKwon commented on a change in pull request #35048: [SPARK-37727][SQL][TESTS][FOLLOW-UP] Add test cases for logs in SparkSession.builder.getOrCreate

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #35048:
URL: https://github.com/apache/spark/pull/35048#discussion_r776177335



##########
File path: core/src/test/scala/org/apache/spark/SparkFunSuite.scala
##########
@@ -249,6 +249,7 @@ abstract class SparkFunSuite
       if (level.isDefined) {
         logger.setLevel(level.get)
         logger.get().setLevel(level.get)
+        LogManager.getContext(false).asInstanceOf[LoggerContext].updateLoggers()

Review comment:
       @viirya, I borrowed your fix from https://github.com/apache/spark/pull/35012 but TBH I have less background here. Do you mind reviewing this please? This change fixes the issue in `withLogAppender` where the logger level is not changed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org