[GitHub] [hadoop] fanluoo commented on a diff in pull request #5591: HDFS-16991. fix testMkdirsRaceWithObserverRead

["fanluoo (via GitHub)" <gi...@apache.org>]

fanluoo commented on code in PR #5591:
URL: https://github.com/apache/hadoop/pull/5591#discussion_r1180337304


##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java:
##########
@@ -583,7 +583,6 @@ public void testMkdirsRaceWithObserverRead() throws Exception {
       futures[i] = threadPool.submit(new MkDirRunner(conf2, clientStates[i]));
     }
 
-    Thread.sleep(150); // wait until mkdir is logged

Review Comment:
   > Can we just use GenricTestUtils.waitFor for this case, wait until mkdir gets actually gets logged?
   Thanks for your suggestion
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org