[GitHub] [jclouds] felfert opened a new pull request #68: Fix toolchain setup on jenkins

[GitBox <gi...@apache.org>]

felfert opened a new pull request #68: Fix toolchain setup on jenkins
URL: https://github.com/apache/jclouds/pull/68
 
 
   This PR fixes the jenkins-specific case introduced by my PR #67 where maven is run by jdk8 and then the toolchain-plugin is used to downgrade the toolchain to jdk1.7.
   This was tested successfully in 3 scenarios:
   
   1. Maven executed by JDK7, jenkins profile deactivated
   1. Maven executed by JDK8, jenkins profile deactivated
   3. Maven executed by JDK8, jenkins profile activated and jdk.version set to 1.7
   
   It will **not** work if maven is executed by JDK>=8 **and** jenkins profile is activated **and** jdk.version is set to anything > 1.7 (For that to work, you have to revert this patch)
   
   In my humble opinion, jenkins-specific setup (or any CI for that matter) does not belong into a project's pom.xml. Instead, this should be solved entirely on jenkins itself. (e.g. by setting up a freestyle job instead of a maven job, setting JAVA_HOME in the job environment and then invoking maven in a shell task). This way, any hassle could have been avoided.
   
   Cheers
    -Fritz

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services