You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/26 18:10:31 UTC

[GitHub] [beam] pabloem commented on a diff in pull request #17431: [BEAM-14273] Add integration tests for BQ JSON type for Python BigQueryIO connector

pabloem commented on code in PR #17431:
URL: https://github.com/apache/beam/pull/17431#discussion_r859011483


##########
sdks/python/apache_beam/io/gcp/bigquery.py:
##########
@@ -2190,6 +2190,12 @@ def expand(self, pcoll):
               'A schema must be provided when writing to BigQuery using '
               'Avro based file loads')
 
+      if self.schema and 'JSON' in str(self.schema):

Review Comment:
   hm what if there's a string field called `dataJSON` or something like that? We should probably verify this differently?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org