[jira] [Comment Edited] (CASSANDRA-15113) StorageService.decommission() throws RuntimeException when interrupted

["eBugs (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-15113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834994#comment-16834994 ] 

eBugs edited comment on CASSANDRA-15113 at 5/7/19 6:23 PM:
-----------------------------------------------------------

After looking at the related code, we found that {{throw}} statement may lead to a dead code in its caller, Decommission.execute(). Please correct me if the following reasoning is wrong:

 

Decommision.execute() tries to catch InterruptedException and rethrows it inside a RuntimeException:
{code:java}
try
{
    probe.decommission(); // This eventually calls StorageService.decommision()
} catch (InterruptedException e)
{
    throw new RuntimeException("Error decommissioning node", e);
}{code}
However, since StorageService.decommission() catches all InterruptedException and rethrows only a RuntimeException, the catch block in execute() won't be reached.


was (Author: ebugs-in-cloud-systems):
After looking at related code, we found that {{throw}} statement may lead to a dead code in its caller, Decommission.execute(). Please correct me if the following reasoning is wrong:

 

Decommision.execute() tries to catch InterruptedException and rethrows it inside a RuntimeException:
{code:java}
try
{
    probe.decommission(); // This eventually calls StorageService.decommision()
} catch (InterruptedException e)
{
    throw new RuntimeException("Error decommissioning node", e);
}{code}
However, since StorageService.decommission() catches all InterruptedException and rethrows only a RuntimeException, the catch block in execute() won't be reached.

> StorageService.decommission() throws RuntimeException when interrupted
> ----------------------------------------------------------------------
>
>                 Key: CASSANDRA-15113
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-15113
>             Project: Cassandra
>          Issue Type: Bug
>            Reporter: eBugs
>            Priority: Normal
>
> Dear Cassandra developers, we are developing a tool to detect exception-related bugs in Java. Our prototype has spotted the following {{throw}} statement whose exception class and error message indicate different error conditions.
>  
> Version: Cassandra-3.11 (commit: 123113f7b887370a248669ee0db6fdf13df0146e) 
> File: CASSANDRA-ROOT/src/java/org/apache/cassandra/service/StorageService.java
> Line: 4008 
> {code:java}
> try
> {
>     ...
>     Thread.sleep(timeout);
>     ...
>     unbootstrap(finishLeaving);
> }
> catch (InterruptedException e)
> {
>     throw new RuntimeException("Node interrupted while decommissioning");
> }
> {code}
>  
> {{RuntimeException}} is usually used to represent errors in the program logic (think of one of its subclasses, {{NullPointerException}}), while the error message indicates that an interrupt has occurred. This mismatch be a problem. For example, the callers may miss the possibility that {{StorageService.decommission()}} can be interrupted because it does not throw any {{InterruptedException}}. Or,  the callers trying to handle other {{RuntimeException}} may accidentally (and incorrectly) handle the interrupt.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org