[GitHub] [druid] clintropolis commented on a change in pull request #10437: Remove Expr.visit.

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #10437:
URL: https://github.com/apache/druid/pull/10437#discussion_r495180959



##########
File path: core/src/main/java/org/apache/druid/math/expr/Expr.java
##########
@@ -112,12 +112,6 @@ default String getBindingIfIdentifier()
    */
   String stringify();
 
-  /**
-   * Programmatically inspect the {@link Expr} tree with a {@link Visitor}. Each {@link Expr} is responsible for
-   * ensuring the {@link Visitor} can visit all of its {@link Expr} children before visiting itself
-   */
-  void visit(Visitor visitor);

Review comment:
       Can you remove `Visitor` as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org