You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "peterxcli (via GitHub)" <gi...@apache.org> on 2025/02/15 07:03:51 UTC
[PR] Add performance metrics for key delete operations in FSO [ozone]
peterxcli opened a new pull request, #7883:
URL: https://github.com/apache/ozone/pull/7883
## What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/HDDS-10386 introduce some metrics to deletekey operation. However the delete key request have two type, [that patch](https://github.com/apache/ozone/pull/6321) only add metrics for non-FSO one.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-12320
## How was this patch tested?
existing tests
CI: https://github.com/peterxcli/ozone/actions/runs/13342640410
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] Add performance metrics for key delete operations in FSO [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on code in PR #7883:
URL: https://github.com/apache/ozone/pull/7883#discussion_r1957057344
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/key/TestOMKeyRequest.java:
##########
@@ -140,7 +140,7 @@ public class TestOMKeyRequest {
public void setup() throws Exception {
ozoneManager = mock(OzoneManager.class);
omMetrics = OMMetrics.create();
- metrics = OMPerformanceMetrics.register();
+ perfMetrics = OMPerformanceMetrics.register();
Review Comment:
Should we mock this and make some call verify on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320. Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #7883:
URL: https://github.com/apache/ozone/pull/7883#issuecomment-2682921717
> Could you test it manually on a docker cluster and add a snip of the metrics being populated at the JMX endpoint of OM?
Thanks @Tejaskriya, updated in PR description, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320. Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #7883:
URL: https://github.com/apache/ozone/pull/7883#issuecomment-2714211633
Hi @jojochuang and @tanvipenumudy, sorry to disturb you. Do you think this patch is good to go? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320. Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on PR #7883:
URL: https://github.com/apache/ozone/pull/7883#issuecomment-2755134537
Thanks @adoroszlai @Tejaskriya for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320. Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7883:
URL: https://github.com/apache/ozone/pull/7883#issuecomment-2753480674
Thanks @peterxcli for the patch, @Tejaskriya for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320: Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7883:
URL: https://github.com/apache/ozone/pull/7883#issuecomment-2663384650
Temporarily converted to draft and assigned to myself, to resolve conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-12320. Introduce Metrics for deletekey operation for FSO in OM Service [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7883:
URL: https://github.com/apache/ozone/pull/7883
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org