[GitHub] [flink] dawidwys commented on a change in pull request #11848: [FLINK-17313]fix type validation error when sink table ddl exists column with precision of decimal/varchar

[GitBox <gi...@apache.org>]

dawidwys commented on a change in pull request #11848:
URL: https://github.com/apache/flink/pull/11848#discussion_r414392699



##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/utils/TypeMappingUtils.java
##########
@@ -169,8 +169,7 @@ public static void checkPhysicalLogicalTypeCompatible(
 										logicalFieldName,
 										physicalFieldType,
 										physicalFieldName,
-										"TableSource return type"),
-								cause));
+										"TableSource return type"), cause));

Review comment:
       What I meant is that we can inline the `TableSource return type` into the string. There is no reason for having it as an argument to `String.format()`.:
   ```
   (cause) -> new ValidationException(
   						String.format("Type %s of table field '%s' does not match with " +
   							"the physical type %s of the '%s' field of the "TableSource return type".",
   								logicalFieldType,
   								logicalFieldName,
   								physicalFieldType,
   								physicalFieldName),
   						cause));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org